Commit Graph

33255 Commits

Author SHA1 Message Date
Joshua C. Colp
82c0971e6e app_queue: Add support for applying caller priority change immediately.
The app_queue module provides both an AMI action and a CLI command
to change the priority of a caller in a queue. Up to now this change
of priority has only been reflected to new callers into the queue.

This change adds an "immediate" option to both the AMI action and
CLI command which immediately applies the priority change respective
to the other callers already in the queue. This can allow, for example,
a caller to be placed at the head of the queue immediately if their
priority is sufficient.

Resolves: #202

UserNote: The 'queue priority caller' CLI command and
'QueueChangePriorityCaller' AMI action now have an 'immediate'
argument which allows the caller priority change to be reflected
immediately, causing the position of a caller to move within the
queue depending on the priorities of the other callers.
2023-07-18 13:03:01 +00:00
George Joseph
8aba4a4f88 .github: Fix cherry-pick reminder issues 2023-07-17 09:26:56 -06:00
George Joseph
e46f7892a6 app.h: Move declaration of ast_getdata_result before its first use
The ast_app_getdata() and ast_app_getdata_terminator() declarations
in app.h were changed recently to return enum ast_getdata_result
(which is how they were defined in app.c).  The existing
declaration of ast_getdata_result in app.h was about 1000 lines
after those functions however so under certain circumstances,
a "use before declaration" error was thrown by the compiler.
The declaration of the enum was therefore moved to before those
functions.

Resolves: #200
2023-07-12 17:44:47 +00:00
George Joseph
7c84bf40e0 doc: Remove obsolete CHANGES-staging and UPGRADE-staging 2023-07-12 17:41:45 +00:00
Sean Bright
836f0bed18 res_geolocation: Ensure required 'location_info' is present.
Fixes #189
2023-07-12 17:39:07 +00:00
Mike Bradeen
4929a2c419 Adds manager actions to allow move/remove/forward individual messages
in a particular mailbox folder. The forward command can be used
to copy a message within a mailbox or to another mailbox. Also adds
a VoicemailBoxSummarry, required to retrieve message ID's.

Resolves: #181

UserNote: The following manager actions have been added

VoicemailBoxSummary - Generate message list for a given mailbox

VoicemailRemove - Remove a message from a mailbox folder

VoicemailMove - Move a message from one folder to another within a mailbox

VoicemailForward - Copy a message from one folder in one mailbox
to another folder in another or the same mailbox.
2023-07-12 17:37:36 +00:00
Mike Bradeen
8f8413b494 app_voicemail: add CLI commands for message manipulation
Adds CLI commands to allow move/remove/forward individual messages
from a particular mailbox folder. The forward command can be used
to copy a message within a mailbox or to another mailbox. Also adds
a show mailbox, required to retrieve message ID's.

Resolves: #170

UserNote: The following CLI commands have been added to app_voicemail

voicemail show mailbox <mailbox> <context>
Show contents of mailbox <mailbox>@<context>

voicemail remove <mailbox> <context> <from_folder> <messageid>
Remove message <messageid> from <from_folder> in mailbox <mailbox>@<context>

voicemail move <mailbox> <context> <from_folder> <messageid> <to_folder>
Move message <messageid> in mailbox <mailbox>&<context> from <from_folder> to <to_folder>

voicemail forward <from_mailbox> <from_context> <from_folder> <messageid> <to_mailbox> <to_context> <to_folder>
Forward message <messageid> in mailbox <mailbox>@<context> <from_folder> to
mailbox <mailbox>@<context> <to_folder>
2023-07-12 17:36:55 +00:00
George Joseph
3bb5cef959 .github: Minor tweak to Asterisk Releaser 2023-07-12 06:49:25 -06:00
George Joseph
e1e294a5e3 .github: Suppress cherry-pick reminder for some situations
In PROpenedOrUpdated, the cherry-pick reminder will now be
suppressed if there are already valid 'cherry-pick-to' comments
in the PR or the PR contained a 'cherry-pick-to: none' comment.
2023-07-11 06:35:39 -06:00
Sean Bright
2291ea7a6b apply_patches: Use globbing instead of file/sort.
This accomplishes the same thing as a `find ... | sort` but with the
added benefit of clarity and avoiding a call to a subshell.

Additionally drop the -s option from call to patch as it is not POSIX.
2023-07-07 15:12:08 +00:00
George Joseph
6dc6d11671 apply_patches: Sort patch list before applying
The apply_patches script wasn't sorting the list of patches in
the "patches" directory before applying them. This left the list
in an indeterminate order. In most cases, the list is actually
sorted but rarely, they can be out of order and cause dependent
patches to fail to apply.

We now sort the list but the "sort" program wasn't in the
configure scripts so we needed to add that and regenerate
the scripts as well.

Resolves: #193
2023-07-06 14:04:16 +00:00
George Joseph
452e0d7258 bundled_pjproject: Backport security fixes from pjproject 2.13.1
Merge-pull-request-from-GHSA-9pfh-r8x4-w26w.patch
Merge-pull-request-from-GHSA-cxwq-5g9x-x7fr.patch
Locking-fix-so-that-SSL_shutdown-and-SSL_write-are-n.patch
Don-t-call-SSL_shutdown-when-receiving-SSL_ERROR_SYS.patch

Resolves: #188
2023-07-05 10:05:50 -06:00
George Joseph
15ecfab8d1 .github: Updates for AsteriskReleaser 2023-06-30 07:02:24 -06:00
Mike Bradeen
f5f09246e2 res_musiconhold: avoid moh state access on unlocked chan
Move channel unlock to after moh state access to avoid
potential unlocked access to state.

Resolves: #133
2023-06-29 15:15:12 +00:00
Mike Bradeen
2822bb3977 utils: add lock timestamps for DEBUG_THREADS
Adds last locked and unlocked timestamps as well as a
counter for the number of times the lock has been
attempted (vs locked/unlocked) to debug output printed
using the DEBUG_THREADS option.

Resolves: #110
2023-06-29 15:13:52 +00:00
George Joseph
e52ad19715 .github: Back out triggering PROpenedOrUpdated by label 2023-06-29 09:07:06 -06:00
George Joseph
a44ac70801 .github: Move publish docs to new file CreateDocs.yml 2023-06-27 12:18:51 -06:00
George Joseph
a41f911ba3 .github: Remove result check from PROpenUpdateGateTests 2023-06-27 05:18:14 -06:00
George Joseph
8c49e751b8 .github: Fix use of 'contains' 2023-06-26 08:45:42 -06:00
George Joseph
f6a323be8d .github: Add recheck label test to additional jobs 2023-06-26 07:46:23 -06:00
George Joseph
523474a2f3 .github: Fix recheck label typos 2023-06-26 07:22:09 -06:00
George Joseph
036951e21a .github: Fix recheck label manipulation 2023-06-26 07:11:58 -06:00
George Joseph
efa4b02a0d .github: Allow PR submit checks to be re-run by label 2023-06-26 07:08:07 -06:00
Ben Ford
8c76507b9f res_pjsip_session: Added new function calls to avoid ABI issues.
Added two new functions (ast_sip_session_get_dialog and
ast_sip_session_get_pjsip_inv_state) that retrieve the dialog and the
pjsip_inv_state respectively from the pjsip_inv_session on the
ast_sip_session struct. This is due to pjproject adding a new field to
the pjsip_inv_session struct that caused crashes when trying to access
fields that were no longer where they were expected to be if a module
was compiled against a different version of pjproject.

Resolves: #145
2023-06-13 17:57:32 +00:00
George Joseph
7dfc190e23 test_statis_endpoints: Fix channel_messages test again 2023-06-12 08:37:56 -06:00
George Joseph
653aee2f13 test_stasis_endpoints.c: Make channel_messages more stable
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
2023-06-09 23:28:12 +00:00
George Joseph
8b93cd97e8 build: Fix a few gcc 13 issues
* gcc 13 is now catching when a function is declared as returning
  an enum but defined as returning an int or vice versa.  Fixed
  a few in app.h, loader.c, stasis_message.c.

* gcc 13 is also now (incorrectly) complaining of dangling pointers
  when assigning a pointer to a local char array to a char *. Had
  to change that to an ast_alloca.

Resolves: #155
2023-06-09 19:03:24 +00:00
George Joseph
2645b68a08 .github: Rework for merge approval 2023-06-08 13:34:50 -06:00
Ben Ford
1f32a01485 AMI: Add CoreShowChannelMap action.
Adds a new AMI action (CoreShowChannelMap) that takes in a channel name
and provides a list of all channels that are connected to that channel,
following local channel connections as well.

Resolves: #104

UserNote: New AMI action CoreShowChannelMap has been added.
2023-06-05 18:30:42 +00:00
George Joseph
1216508654 .github: Fix issues with cherry-pick-reminder 2023-06-05 10:38:31 -06:00
Mike Bradeen
5bfe94461a indications: logging changes
Increase verbosity to indicate failure due to missing country
and to specify default on CLI dump

Resolves: #89
2023-06-05 13:31:57 +00:00
George Joseph
6c43294975 .github Ignore error when adding reviewrs to PR 2023-06-05 07:16:44 -06:00
George Joseph
7c5f7fffb3 .github: Update field descriptions for AsteriskReleaser 2023-05-26 08:52:03 -06:00
George Joseph
0c173be750 .github: Change title of AsteriskReleaser job 2023-05-23 08:05:06 -06:00
George Joseph
1077728ddc .github: Don't add cherry-pick reminder if it's already present 2023-05-22 12:55:06 -06:00
George Joseph
57e3390a81 .github: Fix quoting in PROpenedOrUpdated 2023-05-16 16:12:05 -06:00
George Joseph
6d71d8eea5 .github: Add cherry-pick reminder to new PRs 2023-05-15 09:38:03 -06:00
Sean Bright
e73e5f7ed4 core: Cleanup gerrit and JIRA references. (#40) (#61)
* Remove .gitreview and switch to pulling the main asterisk branch
  version from configure.ac instead.

* Replace references to JIRA with GitHub.

* Other minor cleanup found along the way.

Resolves: #39
2023-05-10 06:17:10 -06:00
Joshua C. Colp
10b40dad53 .github: Tweak improvement issue type language. 2023-05-09 10:47:43 -03:00
Gitea
a74ef79ce2 .github: Tweak new feature language, and move feature requests elsewhere. 2023-05-09 10:43:58 -03:00
Joshua C. Colp
3ef4c8a72c .github: Fix staleness check to only run on certain labels. 2023-05-09 06:18:33 -03:00
George Joseph
493c2debf8 .github: Add AsteriskReleaser 2023-05-08 11:01:57 -06:00
Mike Bradeen
61f4399082 cel: add local optimization begin event
The current AST_CEL_LOCAL_OPTIMIZE event is and has been
triggered on a local optimization end to serve as a flag
indicating the event occurred.  This change adds a second
AST_CEL_LOCAL_OPTIMIZE_BEGIN event for further detail.

Resolves: #52

UpgradeNote: The existing AST_CEL_LOCAL_OPTIMIZE can continue
to be used as-is and the AST_CEL_LOCAL_OPTIMIZE_BEGIN event
can be ignored if desired.

UserNote: The new AST_CEL_LOCAL_OPTIMIZE_BEGIN can be used
by itself or in conert with the existing
AST_CEL_LOCAL_OPTIMIZE to book-end local channel optimizaion.
2023-05-04 14:53:07 +00:00
George Joseph
b9ad757aab .github: Fix CherryPickTest to only run when it should
Fixed CherryPickTest so it triggers only on the
"cherry-pick-test" label instead of all labels.
2023-05-03 09:30:55 -06:00
George Joseph
e95eba5894 .github: Fix reference to CHERRY_PICK_TESTING_IN_PROGRESS 2023-05-02 14:10:15 -06:00
George Joseph
4b982965e9 .github: Remove separate set labels step from new PR 2023-05-02 12:11:48 -06:00
George Joseph
bcfaea4a8b .github: Refactor CP progress and add new PR test progress 2023-05-02 12:05:13 -06:00
George Joseph
8900c3f7a7 .github: Add cherry-pick test progress labels 2023-05-02 08:58:33 -06:00
George Joseph
04668ea95b .github: Update issue templates 2023-05-01 09:38:03 -06:00
George Joseph
d566b3e413 .github: Remove unnecessary parameter in CherryPickTest 2023-05-01 06:52:32 -06:00