Commit Graph

27894 Commits

Author SHA1 Message Date
Joshua Colp
926c1c72bd Merge "res_pjsip_outbound_publish: Use a serializer shutdown group for unload." into 13 2016-08-09 14:44:24 -05:00
Joshua Colp
bf21359292 Merge "app_voicemail: Add taskprocessor alert level options." into 13 2016-08-08 12:32:52 -05:00
Joshua Colp
485fd27f7c res_pjsip_outbound_publish: Use a serializer shutdown group for unload.
This change replaces the custom unload process for the outbound
publish module with the common serializer shutdown group.

ASTERISK-25217 #close

Change-Id: I280a0384d860c486202d87d2d674394cca77ffb6
2016-08-04 15:16:33 +00:00
Corey Farrell
805f105f88 Add missing checks during startup.
This ensures startup is canceled due to allocation failures from the
following initializations.
* channel.c: ast_channels_init
* config_options.c: aco_init

ASTERISK-26265 #close

Change-Id: I911ed08fa2a3be35de55903e0225957bcdbe9611
2016-08-03 16:39:46 -04:00
Alexei Gradinari
ea71bd6e3e app_voicemail: Add taskprocessor alert level options.
On heavy loaded system with IMAP or DB storage,
'app_voicemail' taskprocessor queue could reach 500 scheduled tasks.
It could happen when the IMAP or DB server dies or is unreachable.
It could happen on startup when there are many (thousands)
realtime endpoints configured with unsolicited mwi.
If the taskprocessor queue reaches the high water level
then the alert is triggered and pjsip stops processing new requests
until the queue reaches the low water level to clear the alert.

This patch adds 2 new 'general' configuration options
to tune taskprocessor alert levels:
'tps_queue_high' - Taskprocessor high water alert trigger level.
'tps_queue_low' - Taskprocessor low water clear alert level

ASTERISK-26229 #close

Change-Id: I766294fbffedf64053c0d9ac0bedd3109f043ee8
2016-08-03 14:56:45 -05:00
Joshua Colp
9dc8cfabd5 astconfigparser: Really handle case where line is simply a comment.
The regular expression would match causing the code that handled
the line if it was merely a comment to never get executed.

Change-Id: I3e4022481037ebcba9905587fe8c764b4ce21819
2016-08-03 14:47:04 +00:00
zuul
9db6cdba1a Merge "asterisk.c: Add auto generation and persistence of UUID" into 13 2016-08-02 19:05:42 -05:00
zuul
bc43220fc6 Merge "Remove SILK payload mappings from Asterisk core." into 13 2016-08-02 18:32:11 -05:00
Joshua Colp
2a0f42c494 Merge "res_pjsip: SIP/SDP origin (o=) contained square brackets on IP6 transports." into 13 2016-08-02 15:59:51 -05:00
George Joseph
ad3e65433c asterisk.c: Add auto generation and persistence of UUID
Upcoming features will require the generation and persistence
of a UUID.

Change-Id: I3ec0062427e133217db6ef496a4216f427c3b92d
2016-08-02 14:20:10 -06:00
Joshua Colp
85f9642420 Merge "menuselect: Add an opaque "member_data" string to the acceptable xml" into 13 2016-08-02 14:17:22 -05:00
Joshua Colp
f1b0286aa4 Merge "rest-api: Code out of sync with the model" into 13 2016-08-02 13:36:18 -05:00
Kevin Harwell
efc4034d72 rest-api: Code out of sync with the model
Change-Id: Idccaa26fd4a423d47d013ee592b8fa6a0349c006
2016-08-02 13:02:24 -05:00
Joshua Colp
9d59de79c9 Merge "sorcery: Use more compatible regex for local expressions." into 13 2016-08-02 12:21:12 -05:00
Mark Michelson
f6821fbaec Remove SILK payload mappings from Asterisk core.
SILK is a bit of a hog when it comes to using up our limited number of
dynamic payload types in the RTP engine. By freeing up four slots, it
allows for other codecs to potentially take the place.

Now, codec_silk.so will dynamically use the payload slots in the RTP
engine when it loads.

A better fix would be make RTP dynamic payload types actually
dynamic. However, at this stage of Asterisk 14 development, this is a
risky move that would be imprudent.

Change-Id: I5774e09408f9a203db189529eabdc0d3f4c1e612
(cherry picked from commit d50895c7b0)
2016-08-02 10:50:34 -05:00
Joshua Colp
829b4ba8b3 Merge "pjproject: fixed a few bugs" into 13 2016-08-02 09:34:39 -05:00
Joshua Colp
102d28c11a sorcery: Use more compatible regex for local expressions.
This changes the use of an empty regex for both res_sorcery_config
and res_sorcery_memory to "." instead. This is a more compatible
regular expression which also works on FreeBSD.

ASTERISK-26206 #close

Change-Id: Ia9166dd176f1597555ba22b6931180d0626c1388
2016-08-02 10:25:16 +00:00
Alexander Traud
b78d10a2df res_pjsip: SIP/SDP origin (o=) contained square brackets on IP6 transports.
ASTERISK-26256 #close

Change-Id: I3fd68df561f81fdb8c6c497d465b50c12422f058
2016-08-02 03:15:54 -05:00
George Joseph
1f95c011c7 menuselect: Add an opaque "member_data" string to the acceptable xml
Change-Id: Id5ac43b95c8d7395f3be37f983632169db3d1afe
2016-08-01 15:13:17 -06:00
zuul
104b17eea9 Merge "Replace strdupa with more portable ast_strdupa" into 13 2016-08-01 15:36:50 -05:00
zuul
1e64f4a295 Merge "menuselect: Various menuselect enhancements" into 13 2016-08-01 15:26:10 -05:00
zuul
b8fb794e53 Merge "astconfigparser: Handle case where line is simply a comment." into 13 2016-08-01 15:05:04 -05:00
David M. Lee
df42f64d62 Replace strdupa with more portable ast_strdupa
The strdupa function is a GNU extension, and not widely portable. We
have an ast_strdupa function used within Asterisk which is preferred.
I pulled the definition up from menuselect.c into the menuselect.h
header file so it can be shared across menuselect.

Change-Id: I9593c97f78386b47dc1e83201e80cb2f62b36c2e
2016-08-01 10:53:19 -06:00
George Joseph
56a07fbab9 menuselect: Various menuselect enhancements
* Add 'external' as a support level.
* Add ability for module directories to add entries to the menu
  by adding members to the <module_prefix>/<module_prefix>.xml file.
* Expand the description field to 3 lines in the ncurses implementation.
* Allow the description field to wrap in the newt implementation.
* Add description field to the gtk implementation.

Change-Id: I7f9600a1984a42ce0696db574c1051bc9ad7c808
(cherry picked from commit 90f445729d)
2016-08-01 11:46:36 -05:00
zuul
948a9b615f Merge "pbx.c: Fix handling of '-' in extension name and callerid" into 13 2016-08-01 10:25:19 -05:00
zuul
f2a93dc9f2 Merge "pjproject_bundled: Update for pjproject 2.5.5" into 13 2016-07-29 11:30:42 -05:00
zuul
c2aed1c6e0 Merge "pbx.c: Allow dangerous functions when adding a hint to dialplan." into 13 2016-07-29 06:27:20 -05:00
Joshua Colp
7f9369c1b6 astconfigparser: Handle case where line is simply a comment.
Change-Id: I2dea5815363f4d787d709228a04f33baee383ef5
2016-07-29 06:48:32 -03:00
Joshua Colp
cc5660406c Merge "dsp.c: Add fax and DTMF detection unit tests." into 13 2016-07-28 19:40:42 -05:00
Joshua Colp
cc825e54b0 Merge "dsp.c: Added descriptive comments to Goertzel calculations." into 13 2016-07-28 19:40:37 -05:00
Joshua Colp
323042d99d Merge "dsp.c: Fix incorrect format reference typo." into 13 2016-07-28 19:40:33 -05:00
zuul
d5e380b8fb Merge "dsp.c: Correct DTMF twist dsp.conf documentation." into 13 2016-07-28 19:34:53 -05:00
Joshua Colp
78de6eabbc Merge "astconfigparser.py: Update with realtime fixes." into 13 2016-07-28 19:18:00 -05:00
Corey Farrell
57e9c66819 pbx.c: Fix handling of '-' in extension name and callerid
This adds a two strings to ast_exten.  name to go with exten and
cidmatch_display to go with cidmatch.  The new fields contain input used
to add the extension in the first place.  The existing fields now
contain stripped input that excludes insignificant spaces and dashes.
These stripped fields should always be used for comparisons.  The
unstripped fields should normally be used for display, but displaying
stripped values will not cause runtime errors.

Note the actual string is only stored twice if it contains dashes.  If
no dashes are found then both 'char *' fields point to the same memory.
So this change has a minimum effect on memory usage.

The existing functions ast_get_extension_name and
ast_get_extension_cidmatch return unstripped values as they did before
this change.  Other similar bugs likely still exist where unstripped
extensions are saved outside pbx.c then passed back in.

ASTERISK-26233 #close

Change-Id: I6cd61ce57acc1570ca6cc14960c4c3b0a9eb837f
2016-07-28 20:00:23 -04:00
Richard Mudgett
873fc0fda5 pbx.c: Allow dangerous functions when adding a hint to dialplan.
We can allow dangerous functions when adding a hint since altering
dialplan is itself a privileged activity.  Otherwise, we could never
execute dangerous functions.

ASTERISK-25996 #close
Reported by: Andrew Nagy

Change-Id: I4929ff100ad1200a0198262d069a34f2296e77ba
2016-07-28 15:10:18 -05:00
zuul
7883f128d5 Merge "rtp_engine: Failed assertion and wrong name given for codec" into 13 2016-07-28 13:14:16 -05:00
Alexei Gradinari
f00525a6f6 pjproject: fixed a few bugs
This patch fixes the issue in pjsip_tx_data_dec_ref()
when tx_data_destroy can be called more than once,
and checks if invalid value (e.g. NULL) is passed to.

This patch updates array limit checks and docs
in pjsip_evsub_register_pkg() and pjsip_endpt_add_capability().

Change-Id: I4c7a132b9664afaecbd6bf5ea4c951e43e273e40
2016-07-28 11:04:55 -04:00
George Joseph
972cee2e4c pjproject_bundled: Update for pjproject 2.5.5
Add more --disable-* switches to Makefile.rules including
--disable-opus which was causing bundled pjproject to fail with
"undefined reference" errors in libasteriskpj.

Changed PJ_ENABLE_EXTRA_CHECK to 1.

Removed 2 obsolete patches and added a new one.
The new one was merged by Teluu on 6/27/2016.

ASTERISK-26148 #close

Change-Id: Ib8af6c6a9d31f7238ce65b336134c2efdc855063
2016-07-28 07:04:12 -06:00
David M. Lee
8902a51d59 Portably sscanf tv_usec
In a timeval, tv_usec is defined as a suseconds_t, which could be
different underlying types on different platforms. Instead of trying to
scanf directly into the timeval, scanf into a long int, then copy that
into the timeval.

Change-Id: I29f22d049d3f7746b6c0cc23fbf4293bdaa5eb95
2016-07-27 12:48:17 -05:00
Kevin Harwell
852e763571 rtp_engine: Failed assertion and wrong name given for codec
Fixed an assert check that would trigger when the passed in value was negative.
The negative value was being cast to an unsigned value. This resulted in the
check failing.

Also fixed another problem when loading formats in the engine. When setting the
mime type the format's name was being passed in instead of the codec's name.

Change-Id: I1a201cd419ba4d8e9a40d337e36b6fbe1737192c
2016-07-27 12:45:30 -05:00
Richard Mudgett
e8c34680ca dsp.c: Add fax and DTMF detection unit tests.
* Add fax amplitude and frequency sweep tests.
* Add DTMF amplitude and twist unit tests.

Change-Id: I8d77c9a1eec89e440d715f998c928687e870c3f7
2016-07-26 17:51:06 -05:00
Richard Mudgett
c1f240b818 dsp.c: Added descriptive comments to Goertzel calculations.
* Added doxygen to describe some struct members and what is going on in
the code.

Change-Id: I2ec706a33b52aee42b16dcc356c2bd916a45190d
2016-07-26 17:51:05 -05:00
Richard Mudgett
003a52fd62 dsp.c: Fix incorrect format reference typo.
Change-Id: Ia131da3ec29acf385cb43a586a29ecc975eb3896
2016-07-26 17:51:05 -05:00
Richard Mudgett
4c0a0cbe02 dsp.c: Correct DTMF twist dsp.conf documentation.
Change-Id: Idf97e3a72f1edc5fca58f2fa7b20785922be0cae
2016-07-26 17:50:47 -05:00
Joshua Colp
87433c2566 astconfigparser.py: Update with realtime fixes.
When configuring SIP URIs in the pjsip.conf file it is
necessary to escape the semicolon so the parser does not
treat it as a comment. This change allows this to work in
the astconfigparser implementation.

A secondary bug where some data was lost if a configuration
option included a "=" in its value was also fixed.

A bug where sections would be considered equal despite
being different has also been fixed.

Change-Id: If229f656ef22050b50e7b34e90c4bffe796431f8
2016-07-26 19:29:52 -03:00
Richard Mudgett
159e437e5a dsp.c: Fix erroneous fax tone detection.
The Goertzel calculations get less accurate the lower the signal level
being worked with becomes because there is less resolution remaining.
If it is too low we can erroneously detect a tone where none really
exists.  The searched for fax frequencies not only need to be so much
stronger than the background noise they must also be a minimum strength.

* Add needed minimum threshold test to tone_detect().

* Set TONE_THRESHOLD to allow low volume frequency spread detection.

ASTERISK-26237 #close
Reported by: Richard Mudgett

Change-Id: I84dbba7f7628fa13720add6a88eae3b129e066fc
2016-07-25 23:20:41 -05:00
zuul
7ec9819403 Merge "Fix sqlalchemy error regarding identifier length." into 13 2016-07-23 16:54:27 -05:00
zuul
17e0e058ca Merge "chan_sip: Enable Session-Timers for SIP over TCP (and TLS)." into 13 2016-07-22 16:55:13 -05:00
Mark Michelson
eda95236d1 Fix sqlalchemy error regarding identifier length.
sqlalchemy was complaining:

sqlalchemy.exc.IdentifierError: Identifier
'ps_contacts_qualifyfreq_exptime' exceeds maximum length of 30
characters

This fixes the problem by changing the index name to be
"ps_contacts_qualifyfreq_exp" instead.

ASTERISK-26227 #close
Reported by Mark Michelson

Change-Id: I0ed784f87504be2a59ee8d3242ef6f625d5ed1a9
2016-07-22 14:44:50 -05:00
zuul
8d6a7b89bd Merge "res_pjsip: Whitespace and comment cleanup." into 13 2016-07-22 07:13:13 -05:00