Commit Graph

29325 Commits

Author SHA1 Message Date
Jenkins2
a1d6920745 Merge "Modules: Additional improvements to CLI completion." into 13 2017-11-03 07:46:19 -05:00
Corey Farrell
bfb0f27c87 Modules: Additional improvements to CLI completion.
Replace 'needsreload' argument with a 'type' argument to specify which
type of modules you want completion.  This provides more accurate CLI
completion for load and unload commands.

* 'module unload' now excludes modules that have active references or are
  not running.
* 'module load' now excludes modules that are already running.
* 'core set debug [atleast] <level> [module]' shows running modules only.

ASTERISK-27378

Change-Id: Iea3e00054461484196c46f688f02635cc886bad1
2017-11-02 07:31:20 -05:00
Sean Bright
d524ad523d pjsip_message_filter: Only do interface lookup for wildcard addresses.
Change-Id: Ie083987e69dc43b6861671c218cacacc11b2072f
2017-11-01 14:59:13 -04:00
Kevin Harwell
a7c00707a5 features: Bridge application's BRIDGERESULT not appropriately set
The dialplan application "Bridge" was not setting the BRIDGERESULT to failure
when a failure did occur. Even worse if it did fail to join the bridge it would
still report success.

This patch now sets the BRIDGERESULT variable to an appropriate value for a
given condition state. Also, removed the value INCOMPATIBLE as a valid result
type since it is no longer used.

ASTERISK-27369 #close

Change-Id: I22588e7125a765edf35cff28c98ca143e9927554
2017-10-31 15:08:38 -05:00
Jenkins2
ae2687494a Merge "ast_coredumper: allow setting asterisk binary explicitly" into 13 2017-10-31 07:00:50 -05:00
Jenkins2
71d3f2cb90 Merge "Build System: Fix --disable-xmldoc option." into 13 2017-10-31 06:17:48 -05:00
Jenkins2
6b14200093 Merge "Modules: Fix issues with CLI completion." into 13 2017-10-30 17:04:04 -05:00
Jenkins2
a87391cfcb Merge "app_agent_spool: Fix typo in dtmf features usage desctiption" into 13 2017-10-30 11:25:35 -05:00
Jenkins2
835db751e1 Merge "ast_coredumper: Add gzipping of binaries and display of signal info" into 13 2017-10-30 10:19:55 -05:00
Tzafrir Cohen
1b535d8457 ast_coredumper: allow setting asterisk binary explicitly
Adds an extra option, --asterisk-bin=<path> to ast_coredumper. If
provided, the binary given to gdb will be the parameter, rather than
asterisk from the PATH.

ASTERISK-27380 #close

Change-Id: I25f5b91eb75059b0fb2f142e468c26b283b0a9f3
2017-10-30 09:58:48 -05:00
Corey Farrell
cee81b3c8b Modules: Fix issues with CLI completion.
* Stop using ast_module_helper to check if a module is loaded, use
  ast_module_check instead (app_confbridge and app_meetme).
* Stop ast_module_helper from listing reload classes when needsreload
  was not requested.

ASTERISK-27378

Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239
2017-10-30 00:40:12 -05:00
Igor Goncharovskiy
8436f1d35a app_agent_spool: Fix typo in dtmf features usage desctiption
Fix typo, that specify usage wrong option 'dtmf-features' for CHANNEL() function
instead of correct 'dtmf_features'

ASTERISK-27377 #close

Change-Id: I15ecc829c1035b359584673e12cdb5c9291ac930
2017-10-29 06:18:21 +06:00
Corey Farrell
987b16e8f9 res_pjsip_pubsub: Resolve potential crash in allocate_subscription.
When allocate_subscription fails to initialize fields of the new sub it
calls destroy_subscription.

Change-Id: I5b79c915ec216dc00c13c1e4172137864a4bec85
2017-10-27 13:53:30 -05:00
Joshua Colp
2e5e7e0b14 Merge "codec.c: Defensively check the returned samples." into 13 2017-10-27 09:05:53 -05:00
Jenkins2
a1467ab7bc Merge "app_voicemail.c: Fix compiler warning with IMAP build." into 13 2017-10-27 08:28:43 -05:00
Joshua Colp
40d30cd70e Merge "res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint." into 13 2017-10-26 18:28:13 -05:00
Richard Mudgett
2db97ee219 app_voicemail.c: Fix compiler warning with IMAP build.
ASTERISK-27181

Change-Id: Ic4468b49860bd7f67e922baf4c9e96828c184d17
2017-10-26 12:18:00 -05:00
Richard Mudgett
ca7f3d297b codec.c: Defensively check the returned samples.
Earlier versions of the codec_opus samples_count callback can return
negative error values on undecodable frames.  This resulted in a divide by
zero exception.

* Added a defensive check in ast_codec_samples_count() for a "negative"
samples count return value.  Log the event and set the count to zero.

ASTERISK-27194

Change-Id: Icf69350307ecbbc80a3d74de46af9bd80ea17819
2017-10-26 11:48:23 -05:00
Joshua Colp
7385d1e017 res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.
When the identify_by option on an endpoint is set to ip it will
only be identified using the res_pjsip_endpoint_identifier_ip module.
This ensures that it is not mistakenly matched using the username of
the From header. To ensure behavior has not changed the default has
been changed to "username,ip" for the identify_by option.

ASTERISK-27206

Change-Id: I2170b86a7f7e221b4f00bf14aa1ef1ac5b050bbd
2017-10-25 18:13:26 +00:00
Joshua Colp
28368b3553 Merge "http.c: Fix http header send content." into 13 2017-10-25 12:42:09 -05:00
George Joseph
3f7ad66245 ast_coredumper: Add gzipping of binaries and display of signal info
The --tarball-coredump option now creates a gzipped tarball of
coredumps processed, their results txt files and copies of
/etc/os-release, /usr/sbin/asterisk, /usr/lib(64)/libasterisk* and
/usr/lib(64)/asterisk as those files are needed to properly examine
the coredump.  The file will be named
/tmp/asterisk.<timestamp>.coredumps.tar.gz or
/tmp/asterisk-<uniqueid>.coredumps.tar.gz if --tarball-uniqueid was
specified.

Added dumps of *_siginfo to the top of the txt files so you can
tell what signal was invoked.

Change-Id: Ib9ee6d83592d4b1bc90cb3419a05376a88d1ded9
2017-10-25 11:26:06 -06:00
Corey Farrell
4772849016 Build System: Fix --disable-xmldoc option.
The configure option to disable XML documentation does not currently
work.  This patch makes it effective, but also causes an ABI change by
removing the ast_xmldoc_* symbols.  Disabling xmldoc also prevents docs
from being automatically generated, but they can still be manually
generated with 'make doc/core-en_US.xml'.

ASTERISK-26639

Change-Id: Ifac562340c09f80c83e0203de098fcac93bf8c44
2017-10-25 10:26:16 -05:00
Ben Ford
dfe00b80e7 http.c: Fix http header send content.
Currently ast_http_send barricades a portion of the content that
needs to be sent in order to establish a connection for things
like the ARI client. The conditional and contents have been changed
to ensure that everything that needs to be sent, will be sent.

ASTERISK-27372

Change-Id: I8816d2d8f80f4fefc6dcae4b5fdfc97f1e46496d
2017-10-25 10:18:33 -05:00
Joshua Colp
cf63db7217 Merge "chan_sip: Fix SUBSCRIBE with missing "Expires" header." into 13 2017-10-25 07:44:17 -05:00
Jenkins2
271780019a Merge "hashtab: Use ast_free." into 13 2017-10-25 07:10:14 -05:00
Jenkins2
02538548e6 Merge "res_pjsip_sdp_rtp: Fix setting of address type for rtp_ipv6" into 13 2017-10-25 06:26:27 -05:00
Corey Farrell
23d05ebc49 hashtab: Use ast_free.
A few places in hashtab use free instead of ast_free.

Change-Id: I2ff089bad71640c03c3ce97f1b00fc962ef79427
2017-10-24 17:17:53 -04:00
Jenkins2
65b3c68230 Merge "main/Makefile: Remove rule for non-existant testexpr2." into 13 2017-10-24 15:55:05 -05:00
Jenkins2
8cb61c6f40 Merge "res_xmpp: Ensure the connection filter is available." into 13 2017-10-24 14:59:56 -05:00
Jenkins2
56082b6b4d Merge "lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE." into 13 2017-10-24 14:31:27 -05:00
Jenkins2
529e8e2afa Merge "test_config: Fix failure and segfault when config_hook is run twice." into 13 2017-10-24 13:42:28 -05:00
Corey Farrell
c95ab4c1ce chan_sip: Fix SUBSCRIBE with missing "Expires" header.
When chan_sip receives a SUBSCRIBE request with no "Expires" header it
processes the request as an unsubscribe.  This is incorrect, per RFC3264
when the "Expires" header is missing a default expiry should be used.

ASTERISK-18140

Change-Id: Ibf6dcd4fdd07a32c2bc38be1dd557981f08188b5
2017-10-24 11:03:35 -05:00
Jenkins2
e7d8b4ebe7 Merge "res_pjproject.c: Upgrade bundled PJPROJECT to 2.7" into 13 2017-10-24 09:26:47 -05:00
Jenkins2
3440f535db Merge "chan_sip: Crypto attribute not last but first on SDP media level." into 13 2017-10-24 08:50:47 -05:00
Alexander Traud
5351e862ee lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE.
ASTERISK-23556
Reported by: Marcello Ceschia

Change-Id: Ic27e88e0336a0d83877dc857938659dc5560b93c
2017-10-24 07:28:49 -05:00
Corey Farrell
ec278955a3 main/Makefile: Remove rule for non-existant testexpr2.
Change-Id: Ibb3e47f27a395d74d8c5263db015b05434f5969b
2017-10-23 14:46:03 -04:00
Corey Farrell
6cec3149be test_config: Fix failure and segfault when config_hook is run twice.
On second run the config_hook test was unexpectedly failing to load
test_config.conf because it was still unmodified since the last load.
This is fixed by not passing CONFIG_FLAG_FILEUNCHANGED for the initial
loads, only using it when we are tested that a reload of unmodified
files do not initiate the hook.

ASTERISK-25960

Change-Id: Ifd679509a23ed163e5cc647490bf7df4ae3cd856
2017-10-23 12:46:09 -05:00
George Joseph
4a2575a107 res_pjsip_sdp_rtp: Fix setting of address type for rtp_ipv6
create_outgoing_sdp_stream was setting "addr_type = STR_IP6" only
when an ipv6 media_address was specified on the endpoint.  If
rtp_ipv6 was set and ast_sip_get_host_ip_string returned an ipv6
address, we were leaving the addr_type set at the default of
STR_IP4.  This caused the address type to be set incorrectly on the
"o" and "c" SDP attributes even though the address was set
correctly.  Some clients don't like the mismatch.

 * Removed the test for endpoint/media_address and now check all
   addresses for ipv6.

ASTERISK-27198
Reported by: Martin Cisárik

Change-Id: I5214fc31b728117842243807e7927a319cf77592
2017-10-23 11:23:04 -06:00
Jenkins2
302626c115 Merge "app_agent_pool.c: Fix online documentation typo." into 13 2017-10-23 09:05:03 -05:00
Richard Mudgett
b4cb0050bd app_agent_pool.c: Fix online documentation typo.
Change-Id: Ib0bc95fd0ec288c78c313823254d7a84ebfc4429
2017-10-23 07:53:48 -05:00
Joshua Colp
07e17fd04f res_xmpp: Ensure the connection filter is available.
Users of the API that res_xmpp provides expect that a
filter be available on the client at all times. When
OAuth authentication support was added this requirement
was not maintained.

This change merely moves the OAuth authentication to
after the filter is created, ensuring users of res_xmpp
can add things to the filter as needed.

ASTERISK-27346

Change-Id: I4ac474afe220e833288ff574e32e2b9a23394886
2017-10-22 19:33:13 -03:00
Alexander Traud
c7a9a6ef0c chan_sip: Crypto attribute not last but first on SDP media level.
This matches the behavior of the other SIP channel driver, chan_pjsip.

ASTERISK-27365

Change-Id: I8f23a51290a58b75816da2999ed1965441dfc5d6
2017-10-21 03:46:08 -05:00
Richard Mudgett
b57dcc8d9c res_pjproject.c: Upgrade bundled PJPROJECT to 2.7
Update patches included in bundled PJPROJECT for the new version.

ASTERISK-27355

Change-Id: I9ac5dbbffaadca25ad24fac8b9ab615e5ace6083
2017-10-20 14:26:14 -05:00
Corey Farrell
fb4ed70e62 res_pjsip_pubsub: Prevent unload except during shutdown.
Prevent unload of the module as certain pjsip initialization functions
cannot be reversed.  This required a reorder of the module_load so that
the non-reversable pjsip functions are not called until all potential
errors have been ruled out.

ASTERISK-24483

Change-Id: Iee900f20bdd6ee1bfe23efdec0d87765eadce8a7
2017-10-19 10:35:07 -05:00
Joshua Colp
63e536d97f Merge "chan_sip: Fix output of 'sip set debug off'." into 13 2017-10-19 07:45:38 -05:00
Corey Farrell
216251abcb res_pjsip_refer: Prevent unload except during shutdown.
Prevent unload of the module as certain pjsip initialization functions
cannot be reversed.

ASTERISK-24483

Change-Id: I94597ec8b8491f5af9c57bf66dbc3b078fe2d49d
2017-10-18 13:40:24 -05:00
Corey Farrell
7dd7ca2858 chan_sip: Fix output of 'sip set debug off'.
When sip.conf contains 'sipdebug=yes' it is impossible to disable it
using CLI 'sip set debug off'.  This corrects the output of that CLI
command to instruct the user to turn sipdebug off in the configuration
file.

ASTERISK-23462 #close

Change-Id: I1cceade9caa9578e1b060feb832e3495ef5ad318
2017-10-18 12:13:32 -05:00
Jenkins2
dbafed0ed5 Merge "res_corosync: Fix linking issue with Corosync 2.x" into 13 2017-10-17 11:19:02 -05:00
Joshua Colp
c5f671e2df Merge "cdr.c: Rename the Party A CDR container." into 13 2017-10-17 11:06:25 -05:00
Jenkins2
4c83f685e6 Merge "cdr.c: Add container to key off of Party B channel names." into 13 2017-10-17 10:41:26 -05:00