Commit Graph

16307 Commits

Author SHA1 Message Date
Russell Bryant
b55ecb6aea Merged revisions 141807 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141807 | russell | 2008-09-08 16:05:01 -0500 (Mon, 08 Sep 2008) | 15 lines

Merged revisions 141806 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141806 | russell | 2008-09-08 16:02:36 -0500 (Mon, 08 Sep 2008) | 7 lines

When doing an async goto, detect if the channel is already in the middle of a
masquerade.  This can happen when chan_local is trying to optimize itself out.
If this happens, fail the async goto instead of bursting into flames.

(closes issue #13435)
Reported by: geoff2010

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-09 01:51:28 +00:00
Russell Bryant
50c690fb59 Merged revisions 141949 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r141949 | russell | 2008-09-08 20:47:56 -0500 (Mon, 08 Sep 2008) | 9 lines

Modify ast_answer() to not hold the channel lock while calling ast_safe_sleep()
or when calling ast_waitfor().  These are inappropriate times to hold the channel
lock.  This is what has caused "could not get the channel lock" messages from
chan_sip and has likely caused a negative impact on performance results of SIP
in Asterisk 1.6.  Thanks to file for pointing out this section of code.

(closes issue #13287)
(closes issue #13115)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-09 01:50:48 +00:00
Mark Michelson
32b050b676 Blocked revisions 141906 via svnmerge
........
r141906 | mmichelson | 2008-09-08 18:00:06 -0500 (Mon, 08 Sep 2008) | 9 lines

Optimization: The only reason we should check member
status is if the queue has a joinempty or a leavewhenempty
setting which could cause the caller to not join the queue
or exit the queue. Prior to this patch, we could potentially
traverse the entire queue's member list for no reason since
even if the members are currently not available in some way
we're going to let the caller join the queue anyway.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141908 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-08 23:01:03 +00:00
Mark Michelson
d77e8c4d81 Merged revisions 141868 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r141868 | mmichelson | 2008-09-08 17:14:40 -0500 (Mon, 08 Sep 2008) | 4 lines

Um, apparently I didn't actually finish merging before committing.
Bad bad bad


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141870 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-08 22:15:28 +00:00
Mark Michelson
6b1a048869 Merged revisions 141810 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141810 | mmichelson | 2008-09-08 16:18:49 -0500 (Mon, 08 Sep 2008) | 22 lines

Merged revisions 141809 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141809 | mmichelson | 2008-09-08 16:10:10 -0500 (Mon, 08 Sep 2008) | 14 lines

Fix pedantic mode of chan_sip to only check the
remote tag of an endpoint once a dialog has
been confirmed. Up until that point, it is possible
and legal for the far-end to send provisional
responses with a different To: tag each time. With
this patch applied, these provisional messages
will not cause a matching problem.

(closes issue #11536)
Reported by: ibc
Patches:
      11536v2.patch uploaded by putnopvut (license 60)


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141812 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-08 21:20:01 +00:00
Jason Parker
dca0967ba5 Merged revisions 141745 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141745 | qwell | 2008-09-08 15:18:17 -0500 (Mon, 08 Sep 2008) | 16 lines

Merged revisions 141741 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141741 | qwell | 2008-09-08 15:15:42 -0500 (Mon, 08 Sep 2008) | 8 lines

Remove RPM package targets from Makefile (and all associated parts).
This has never worked in 1.4, and we decided that it makes no sense to be done here.
There are many distros out there that already have "proper" spec files that can be (re)used.

Closes issue #13113
Closes issue #10950
Closes issue #10952

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141747 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-08 20:20:01 +00:00
Sean Bright
7dffdb2de2 Merged revisions 141682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r141682 | seanbright | 2008-09-08 13:13:04 -0400 (Mon, 08 Sep 2008) | 9 lines

Quote the arguments to grep so that sh on various platforms doesn't choke
on the special characters (like ^).

(closes issue #13417)
Reported by: dougm
Patches:
      13417.make_buildopts_h.patch uploaded by seanbright (license 71)
Tested by: dougm

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-08 17:15:22 +00:00
Michiel van Baak
b9f6096f8c Blocked revisions 141626 via svnmerge
........
r141626 | mvanbaak | 2008-09-07 02:04:05 +0200 (Sun, 07 Sep 2008) | 2 lines

make func_curl.c compile under devmode.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-07 00:11:57 +00:00
Steve Murphy
39edc9258d Merged revisions 141566 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141566 | murf | 2008-09-06 14:19:50 -0600 (Sat, 06 Sep 2008) | 9 lines

Merged revisions 141565 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141565 | murf | 2008-09-06 14:13:16 -0600 (Sat, 06 Sep 2008) | 1 line

This fix comes from Joshua Colp The Brilliant, who, given the trace, came up with a solution. This will most likely will close 13235 and 13409. I'll wait till Monday to verify, and then close these bugs.
........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-06 20:23:58 +00:00
Tilghman Lesher
925b1f86ba Blocked revisions 141507 via svnmerge
........
r141507 | tilghman | 2008-09-06 10:40:15 -0500 (Sat, 06 Sep 2008) | 5 lines

Get rid of the casts that cause warnings on OpenBSD.  The compiler is errantly
detecting warnings when we redefine a structure each time it is used, even
though the structure is identical.
Reported by: mvanbaak, via #asterisk-dev

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-06 15:41:13 +00:00
Tilghman Lesher
f7ca7e7e61 Merged revisions 141504 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141504 | tilghman | 2008-09-06 10:26:45 -0500 (Sat, 06 Sep 2008) | 12 lines

Merged revisions 141503 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141503 | tilghman | 2008-09-06 10:23:42 -0500 (Sat, 06 Sep 2008) | 4 lines

Reverting behavior change (AGI should not exit non-zero on SUCCESS)
(closes issue #13434)
 Reported by: francesco_r

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-06 15:28:59 +00:00
Michiel van Baak
ebe03c35f7 Blocked revisions 141464 via svnmerge
........
r141464 | mvanbaak | 2008-09-06 14:03:11 +0200 (Sat, 06 Sep 2008) | 23 lines

Some fixes to autocompletion in some commands.

Changes applied by this patch:

- Fix autocompletion in 'sip prune realtime', sip peers where never auto completed. Now we complete this command with:
  'sip prune realtime peer' -> all | like | sip peers
  Also I have modified the syntax in the usage, was wrong...
- Pass ast_cli_args->argv and ast_cli_args->argc while running autocompletion on CLI commands (CLI_GENERATE).
  With this we avoid comparisons on ast_cli_args->line like this:
  strcasestr(a->line, " description")
  strcasestr(a->line, "descriptions ")
  strcasestr(a->line, "realtime peer"), and so on..

  Making the code more confusing (check the spaces in description!).
  The only thing we must be sure is to first check a->pos or a->argc.
														      
- Fix 'iax2 prune realtime' autocompletion, now we autocomplete this command with 'all' & 'iax2 peers', check a look that iax2 peers where all the peers, now only the ones in the cache..

(closes issue #13133)
Reported by: eliel
Patches:
      clichanges.patch uploaded by eliel (license 64)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-06 12:04:30 +00:00
Mark Michelson
97f84ef108 Blocked revisions 141425 via svnmerge
........
r141425 | mmichelson | 2008-09-05 17:03:26 -0500 (Fri, 05 Sep 2008) | 3 lines

Fix func_curl compilation


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141427 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-05 22:06:29 +00:00
Mark Michelson
dbb3d279a6 Merged revisions 141367 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141367 | mmichelson | 2008-09-05 16:12:09 -0500 (Fri, 05 Sep 2008) | 15 lines

Merged revisions 141366 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141366 | mmichelson | 2008-09-05 16:10:32 -0500 (Fri, 05 Sep 2008) | 7 lines

Agent's should not try to call a channel's indicate callback
if the channel has been hung up. It will likely crash
otherwise

ABE-1159


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-05 21:13:35 +00:00
Tilghman Lesher
4fdd3c1fa8 Blocked revisions 141328 via svnmerge
........
r141328 | tilghman | 2008-09-05 14:12:03 -0500 (Fri, 05 Sep 2008) | 8 lines

Add the CURLOPT dialplan function, which permits setting various options for
use with the CURL dialplan function.
(closes issue #12920)
 Reported by: davevg
 Patches: 
       20080904__bug12920.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76, davevg

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141330 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-05 19:14:06 +00:00
Mark Michelson
9336eafb9b Blocked revisions 141271 via svnmerge
................
r141271 | mmichelson | 2008-09-05 11:36:48 -0500 (Fri, 05 Sep 2008) | 18 lines

Blocked revisions 141267 via svnmerge

........
r141267 | mmichelson | 2008-09-05 11:35:54 -0500 (Fri, 05 Sep 2008) | 11 lines

Since greetings are not stored in IMAP, we should
not be DISPOSE'ing of them the same way we do with
other messages.

(closes issue #13414)
Reported by: mthomasslo
Patches:
      13414v2.patch uploaded by putnopvut (license 60)
Tested by: mthomasslo


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-05 16:37:35 +00:00
Mark Michelson
57a6c1e97f Blocked revisions 141218 via svnmerge
................
r141218 | mmichelson | 2008-09-05 11:03:11 -0500 (Fri, 05 Sep 2008) | 21 lines

Blocked revisions 141217 via svnmerge

........
r141217 | mmichelson | 2008-09-05 11:00:24 -0500 (Fri, 05 Sep 2008) | 14 lines

Commit 140417 had a logic flaw in it which
caused port 5060 to always be used when dialing
a peer if no explicit port was specified. This
broke the behavior of implicitly using the port
from which the peer registered if no port is
specified. This commit fixes the logic flaw.

(closes issue #13424)
Reported by: mdu113
Patches:
      13424.patch uploaded by putnopvut (license 60)
Tested by: mdu113


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141220 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-05 16:05:17 +00:00
Steve Murphy
aaff8a2a20 Merged revisions 141157 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141157 | murf | 2008-09-05 08:18:43 -0600 (Fri, 05 Sep 2008) | 9 lines

Merged revisions 141156 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141156 | murf | 2008-09-05 08:15:43 -0600 (Fri, 05 Sep 2008) | 1 line

A small change to prevent double-posting of CDR's; thanks to Daniel Ferrer for bringing it to our attention
........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-05 14:25:49 +00:00
Steve Murphy
ea665ed7d9 Merged revisions 141115 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141115 | murf | 2008-09-04 17:31:41 -0600 (Thu, 04 Sep 2008) | 78 lines

Merged revisions 141094 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141094 | murf | 2008-09-04 17:15:07 -0600 (Thu, 04 Sep 2008) | 70 lines

(closes issue #13357)
Reported by: pj
Tested by: murf

(closes issue #13416)
Reported by: yarns
Tested by: murf

If you find this message overly verbose, relax, it's probably
not meant for you. This message is meant for probably only
two people in the whole world: me, or the poor schnook that
has to maintain this code because I'm either dead or unavailable
at the moment.

This fix solves two reports, both having to do with embedding
a function call in a ${} construct. It was tricky because the
funccall syntax has parenthesis () in it. And up till now,
the 'word' token in the flex stuff didn't allow that, because
it would tend to steal the LP and RP tokens. To be truthful,
the "word" token was the trickiest, most unstable thing in
the whole lexer. I was lucky it made this long without complaints.
I had to choose every character in the pattern with extreme
care, and I knew that someday I'd have to revisit it. Well,
the day has come.

So, my brilliant idea (and I'm being modest), was to use the 
surrounding ${} construct to make a state machine and capture 
everything in it, no matter what it contains. But, I have to now
treat the word token like I did with comments, in that I turn
the whole thing into a state-machine sort of spec, with new
contexts "curlystate", "wordstate", and "brackstate".

Wait a minute, "brackstate"? Yes, well, it didn't take very many
regression tests to point out if I do this for ${} constructs,
I also have to do it with the $[] constructs, too.

I had to create a separate pcbstack2 and pcbstack3 because
these constructs can occur inside macro argument lists, and
when we have two state machines operating on the same structures
we'd get problems otherwise. I guess I could have stopped at
pcbstack2 and had the brackstate stuff share it, but it doesn't
hurt to be safe. So, the pcbpush and pcbpop routines also now
have versions for "2" and "3".

I had to add the {KEYWORD} construct to the initial pattern for
"word", because previously word would match stuff like "default7",
because it was a longer match than the keyword "default". But,
not any more, because the word pattern only matches only one or
two characters now, and it will always lose. So, I made it the
winner again by making an optional match on any of the keywords
before it's normal pattern.

I added another regression test to make sure we don't
lose this in future edits, and had to fix just one regression,
where it no longer reports a 'cascaded' error, which I guess
is a plus.

I've given some thought as to whether to apply these fixes to
1.4 and the 1.6.x releases, vs trunk; I decided to put it in
1.4 because one of the bug reports was against 1.4; and it
is unexpected that AEL cannot handle this situation. It actually
reduced the amount of useless "cascade" error messages that
appeared in the regressions (by one line, ehhem). There is
a possible side-effect in that it does now do more careful
checking of what's in those ${} constructs, as far as matching
parens, and brackets are concerned. Some users may find a an
insidious problem and correct it this way. This should be 
exceedingly rare, I hope.


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141117 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-04 23:52:01 +00:00
Jeff Peeler
2a02fcceff Merged revisions 141039 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r141039 | jpeeler | 2008-09-04 12:27:56 -0500 (Thu, 04 Sep 2008) | 15 lines

Merged revisions 141028 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r141028 | jpeeler | 2008-09-04 12:00:29 -0500 (Thu, 04 Sep 2008) | 7 lines

(closes issue #11979)
Fixes multiple parking problems:
Crash when executing a park on an extension dialed by AGI due to not returning the proper return code.
Crash when using a builtin feature that was a subset of a enabled dynamic feature.
Crash due to always hanging up the peer despite the fact that the peer was supposed to be parked.


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@141042 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-04 17:28:41 +00:00
Mark Michelson
c760268cb8 Merged revisions 140975 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140975 | mmichelson | 2008-09-03 15:16:12 -0500 (Wed, 03 Sep 2008) | 4 lines

Fix some locking order issues in app_queue. This was
brought up by atis on IRC a while ago.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140977 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 20:18:58 +00:00
Michiel van Baak
0de49b57b9 Blocked revisions 140938 via svnmerge
........
r140938 | mvanbaak | 2008-09-03 20:06:35 +0200 (Wed, 03 Sep 2008) | 12 lines

Added 'skinny show lines verbose'
This will print the subs and their status for every line (if any).

wedhorn did most of the work with his patch which introduced
'skinny show debug' but a discussion on IRC stated that it should be
added to 'skinny show lines'

Input on the output format by Qwell on IRC.

(closes issue #13344)
Reported by: wedhorn

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140940 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 18:10:30 +00:00
Mark Michelson
04a5eb09f9 Merged revisions 140887 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140887 | mmichelson | 2008-09-03 09:41:54 -0500 (Wed, 03 Sep 2008) | 3 lines

Fix compilation


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140888 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 14:42:54 +00:00
Steve Murphy
09fe3752a5 Merged revisions 140824 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140824 | murf | 2008-09-03 08:01:27 -0600 (Wed, 03 Sep 2008) | 21 lines

In these changes, I have added some explanation
of changes to the Set and MSet apps, so people aren't
so shocked and surprised when they upgrade from
1.4 to 1.6.

Also, for the sake of those upgrading from 1.4 to
1.6 with AEL, I provide automatic support for the 
"old" way of using Set(), that still does the
exact same old thing with quotes and backslashes
and so on as 1.4 did, by having AEL compile in the
use of MSet() instead of Set(), everywhere it inserts
this code.

But, if the app_set var is set to 1.6 or higher,
it uses the "new", non-evaluative Set().

This only usually happens if the user manually 
inserts this into the asterisk.conf file, or runs
the "make samples" command.

(closes issue #13249)
Reported by: dimas
Patches:
      ael-MSet.diff uploaded by murf (license 17)
Tested by: dimas, murf
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 14:39:04 +00:00
Mark Michelson
df5a83a941 Merged revisions 140860 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140860 | mmichelson | 2008-09-03 09:31:33 -0500 (Wed, 03 Sep 2008) | 17 lines

Merged revisions 140850 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140850 | mmichelson | 2008-09-03 09:29:15 -0500 (Wed, 03 Sep 2008) | 9 lines

Fix voicemail forwarding when using ODBC storage.

(closes issue #13387)
Reported by: moliveras
Patches:
      13387.patch uploaded by putnopvut (license 60)
Tested by: putnopvut, moliveras


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 14:32:57 +00:00
Sean Bright
71d4b5acde Blocked revisions 140821 via svnmerge
........
r140821 | seanbright | 2008-09-03 09:48:12 -0400 (Wed, 03 Sep 2008) | 10 lines

Move some duplicated code into a separate function.

Also try to do some wacky stuff in the commit message, like:
a newline \n
a bell \a
a tab \t
a format specification %p

That is all.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140823 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 13:50:55 +00:00
Russell Bryant
d01749ba43 Merged revisions 140817 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140817 | russell | 2008-09-03 08:26:43 -0500 (Wed, 03 Sep 2008) | 12 lines

Merged revisions 140816 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140816 | russell | 2008-09-03 08:24:35 -0500 (Wed, 03 Sep 2008) | 4 lines

Don't freak out if the poll emulation receives NULL for the pollfds array
(closes issue #13307)
Reported by: jcovert

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-03 13:27:33 +00:00
Mark Michelson
315bd4e87d Merged revisions 140752 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140752 | mmichelson | 2008-09-02 18:48:25 -0500 (Tue, 02 Sep 2008) | 14 lines

Merged revisions 140751 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140751 | mmichelson | 2008-09-02 18:47:49 -0500 (Tue, 02 Sep 2008) | 6 lines

After adding the context checking to app_voicemail
for IMAP storage, I left out a crucial place to 
copy the context to the vm_state structure. This
is the correction.


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 23:51:03 +00:00
Steve Murphy
9f94f365a7 Merged revisions 140749 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140749 | murf | 2008-09-02 17:44:04 -0600 (Tue, 02 Sep 2008) | 11 lines

Merged revisions 140747 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140747 | murf | 2008-09-02 17:36:56 -0600 (Tue, 02 Sep 2008) | 1 line

I am turning the warnings generated in ast_cdr_free and post_cdr into verbose level 2 messages. Really, they matter little to end users. You either get the CDR's you wanted, or you don't, and it is a bug.

For trunk, I am going one step further. These messages were pretty worthless even for debug, so I'm completely removing them.
........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 23:46:34 +00:00
Steve Murphy
08146f95bc Merged revisions 140692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140692 | murf | 2008-09-02 16:55:12 -0600 (Tue, 02 Sep 2008) | 13 lines

Merged revisions 140690 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140690 | murf | 2008-09-02 16:40:13 -0600 (Tue, 02 Sep 2008) | 1 line

After reconsidering, with respect to 13409, ast_cdr_detach should be OK, better in fact, than ast_cdr_free, which generates lots of useless warnings that will undoubtably generate complaints.

Hmmm. It doesn't hush the useless warnings, but it does allow control of posting via the detach and post routines, for those possible situations,
where you'd want to post single-channel cdrs.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 23:01:35 +00:00
Steve Murphy
0c8172a97c Merged revisions 140691 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140691 | murf | 2008-09-02 16:50:59 -0600 (Tue, 02 Sep 2008) | 22 lines

Merged revisions 140670 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140670 | murf | 2008-09-02 16:15:57 -0600 (Tue, 02 Sep 2008) | 14 lines

(closes issue #13409)
Reported by: tomaso
Patches:
      asterisk-1.6.0-rc2-cdrmemleak.patch uploaded by tomaso (license 564)

I basically spent the day, verifying that this patch 
solves the problem, and doesn't hurt in non-problem 
cases. Why valgrind did not plainly reveal this leak
absolutely mystifies and stuns me. 

Many, many thanks to tomaso for finding and providing the fix.



........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 22:58:50 +00:00
Sean Bright
b354d1ce51 Merged revisions 140606 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140606 | seanbright | 2008-09-02 14:15:54 -0400 (Tue, 02 Sep 2008) | 16 lines

Merged revisions 140605 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140605 | seanbright | 2008-09-02 14:14:57 -0400 (Tue, 02 Sep 2008) | 8 lines

Make sure to use the correct length of the mohinterpret and mohsuggest
buffers when copying configuration values.

(closes issue #13336)
Reported by: decryptus_proformatique
Patches:
      chan_iax2_mohinterpret_mohsuggest_general_settings.patch uploaded by decryptus (license 555)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140608 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 18:18:30 +00:00
Russell Bryant
9c22591766 Merged revisions 140566 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140566 | russell | 2008-09-02 10:11:53 -0500 (Tue, 02 Sep 2008) | 2 lines

Update instructions for getting libresample

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 15:13:10 +00:00
Russell Bryant
a4eea7702d Merged revisions 140563 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140563 | russell | 2008-09-02 10:09:20 -0500 (Tue, 02 Sep 2008) | 3 lines

I'm not sure how these files got to trunk (probably my fault), but they
should not be here

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140565 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 15:10:04 +00:00
Sean Bright
ff8668fdbc Blocked revisions 140559 via svnmerge
........
r140559 | seanbright | 2008-09-02 10:41:41 -0400 (Tue, 02 Sep 2008) | 4 lines

When a call is rejected because of call-limit, the channel driver is behaving
as expected, so we shouldn't report it as an error.  Change to LOG_NOTICE
instead.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140561 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-09-02 14:43:01 +00:00
Jeff Peeler
f86752e905 Merged revisions 140491 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140491 | jpeeler | 2008-08-29 12:53:32 -0500 (Fri, 29 Aug 2008) | 2 lines

Added the option s to the Park application which will silence the announcement of the parking space number. Also, fixes the bug of just clearing the flags instead of actually parsing the arguments to Park.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-29 17:55:14 +00:00
Mark Michelson
6ed6a5ae29 Merged revisions 140489 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140489 | mmichelson | 2008-08-29 12:47:17 -0500 (Fri, 29 Aug 2008) | 30 lines

Merged revisions 140488 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140488 | mmichelson | 2008-08-29 12:34:17 -0500 (Fri, 29 Aug 2008) | 22 lines

After working on the ao2_containers branch, I noticed
something a bit strange. In all cases where we provide
a callback function to ao2_container_alloc, the callback
function would only return 0 or CMP_MATCH. After inspecting
the ao2_callback() code carefully, I found that if you're
only looking for one specific item, then you should return
CMP_MATCH | CMP_STOP. Otherwise, astobj2 will continue
traversing the current bucket until the end searching for
more matches.

In cases like chan_iax2 where in 1.4, all the peers are
shoved into a single bucket, this makes for potentially
terrible performance since the entire bucket will be
traversed even if the peer is one of the first ones come
across in the bucket.

All the changes I have made were for cases where the 
callback function defined was passed to ao2_container_alloc
so that calls to ao2_find could find a unique instance
of whatever object was being stored in the container.


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-29 17:48:07 +00:00
Mark Michelson
5b5666c301 Merged revisions 140433 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140433 | mmichelson | 2008-08-29 11:24:37 -0500 (Fri, 29 Aug 2008) | 10 lines

Allow for video files to be opened as well as
audio files.

(closes issue #13372)
Reported by: epicac
Patches:
      13372.patch uploaded by putnopvut (license 60)
Tested by: epicac


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140435 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-29 16:25:46 +00:00
Mark Michelson
b8520de916 Merged revisions 140422 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140422 | mmichelson | 2008-08-29 11:06:09 -0500 (Fri, 29 Aug 2008) | 20 lines

Merged revisions 140421 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140421 | mmichelson | 2008-08-29 11:01:07 -0500 (Fri, 29 Aug 2008) | 12 lines

Add context checking when retrieving a vm_state.
This was causing a problem for people who had identically
named mailboxes in separate voicemail contexts.
This commit affects IMAP storage only.

(closes issue #13194)
Reported by: moliveras
Patches:
      13194.patch uploaded by putnopvut (license 60)
Tested by: putnopvut, moliveras


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140425 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-29 16:11:50 +00:00
Mark Michelson
41b37a348f Merged revisions 140418 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140418 | mmichelson | 2008-08-29 10:32:02 -0500 (Fri, 29 Aug 2008) | 18 lines

Merged revisions 140417 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140417 | mmichelson | 2008-08-29 10:26:52 -0500 (Fri, 29 Aug 2008) | 10 lines

Fix SIP's parsing so that if a port is specified
in a string to Dial(), it is not ignored.

(closes issue #13355)
Reported by: acunningham
Patches:
      13355v2.patch uploaded by putnopvut (license 60)
Tested by: acunningham


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-29 15:33:49 +00:00
Tilghman Lesher
9a53ace006 Blocked revisions 140355 via svnmerge
........
r140355 | tilghman | 2008-08-27 18:23:56 -0500 (Wed, 27 Aug 2008) | 2 lines

Oops

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140357 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-27 23:25:23 +00:00
Mark Michelson
22ca4c9392 Merged revisions 140301 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140301 | mmichelson | 2008-08-27 15:11:22 -0500 (Wed, 27 Aug 2008) | 19 lines

Merged revisions 140299 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140299 | mmichelson | 2008-08-27 14:49:20 -0500 (Wed, 27 Aug 2008) | 11 lines

Fix tag checking in get_sip_pvt_byid_locked when
in pedantic mode. The problem was that the wrong
tags would be compared depending on the direction
of the call.

(closes issue #13353)
Reported by: flefoll
Patches:
      chan_sip.c.br14.139015.patch-refer-pedantic uploaded by flefoll (license 244)


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-27 20:14:24 +00:00
Jeff Peeler
d0f43c3266 Merged revisions 140205 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140205 | jpeeler | 2008-08-26 13:48:55 -0500 (Tue, 26 Aug 2008) | 17 lines

Merged revisions 140056 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140056 | jpeeler | 2008-08-26 10:57:02 -0500 (Tue, 26 Aug 2008) | 9 lines

(closes issue #12071)
Reported by: tzafrir
Patches:
      dahdi_close.diff uploaded by tzafrir (license 46)
Tested by: tzafrir, jpeeler

This patch fixes closing open file descriptors in the case of an error.


........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140206 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-26 18:50:47 +00:00
Tilghman Lesher
e866ee840f Blocked revisions 140201 via svnmerge
........
r140201 | tilghman | 2008-08-26 13:46:07 -0500 (Tue, 26 Aug 2008) | 2 lines

OpenBSD compat fix (reminded by mvanbaak on #asterisk-dev)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140204 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-26 18:47:51 +00:00
Tilghman Lesher
7ea8a1943e Blocked revisions 140201 via svnmerge
........
r140201 | tilghman | 2008-08-26 13:46:07 -0500 (Tue, 26 Aug 2008) | 2 lines

OpenBSD compat fix (reminded by mvanbaak on #asterisk-dev)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140203 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-26 18:47:27 +00:00
Russell Bryant
0721736fb8 Merged revisions 140169 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r140169 | russell | 2008-08-26 13:11:49 -0500 (Tue, 26 Aug 2008) | 4 lines

Fix building menuselect-tree with PRINT_DIR set.  We _must_ use the --quiet
flag here, or else some arbitrary text will end up in the resulting
menuselect-tree file and things will explode.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140171 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-26 18:12:24 +00:00
Russell Bryant
b2039fd988 Merged revisions 140061 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140061 | russell | 2008-08-26 11:10:06 -0500 (Tue, 26 Aug 2008) | 14 lines

Merged revisions 140060 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140060 | russell | 2008-08-26 11:07:58 -0500 (Tue, 26 Aug 2008) | 6 lines

Fix some bogus scheduler usage in chan_sip.  This code used the return value
of a completely unrelated function to determine whether the scheduler should
be run or not.  This would have caused the scheduler to not run in cases where
it should have.  Also, leave a note about another scheduler issue that needs
to be addressed at some point.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140063 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-26 16:11:23 +00:00
Steve Murphy
d3110eacca Blocked revisions 140057 via svnmerge
........
r140057 | murf | 2008-08-26 09:57:49 -0600 (Tue, 26 Aug 2008) | 21 lines

(closes issue #13366)
Reported by: erousseau

This was a reasonable enhancement request, which was
easy to implement. Since it's an enhancement, it 
could only be applied to trunk.

Basically, for accounting where "initiated" seconds
are billed for, if the microseconds field on the end
time is greater than the microseconds field for the
answer time, add one second to the billsec field.

The implementation was requested by erousseau, and
I've implemented it as requested. I've updated the
CHANGES, the cdr.conf.sample, and the .h files
accordingly, to accept and set a flag for the
corresponding new option. cdr.c adds in the extra
second based on the usec fields if the option is
set. Tested, seems to be working fine.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140059 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-26 16:01:37 +00:00
Russell Bryant
192e6166df Merged revisions 140053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r140053 | russell | 2008-08-26 10:29:25 -0500 (Tue, 26 Aug 2008) | 23 lines

Merged revisions 140051 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140051 | russell | 2008-08-26 10:27:23 -0500 (Tue, 26 Aug 2008) | 15 lines

Fix a race condition with the IAX scheduler thread.  A lock and condition are
used here to allow newly scheduled tasks to wake up the scheduler just in case
the new task needs to run sooner than the current wakeup time when the thread
is sleeping.  However, there was a race condition such that a newly scheduled
task would not properly wake up the scheduler or affect the wake up period.
The order of execution would have been:

  1) Scheduler thread determines wake up time of N ms.
  2) Another thread schedules a task and signals the condition, with an
     execution time of < N ms.
  3) Scheduler thread locks and goes to sleep for N ms.

By moving the sleep time determination to inside the critical section, this
possibility is avoided.

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@140055 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-26 15:31:13 +00:00
Tilghman Lesher
909fbe8947 Blocked revisions 139981 via svnmerge
........
r139981 | tilghman | 2008-08-25 18:13:32 -0500 (Mon, 25 Aug 2008) | 7 lines

Optional light colored background, for those who use black on white terminals.
(closes issue #13306)
 Reported by: Corydon76
 Patches: 
       20080814__bug13306__3.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76, pkempgen

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@139983 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-08-25 23:14:44 +00:00