Commit Graph

30654 Commits

Author SHA1 Message Date
George Joseph
ba068d3576 Merge "res/res_pjsip_nat: Fix logic for REINVITES" into 13 2018-11-18 08:46:09 -06:00
George Joseph
7e83dc6ce5 Merge "taskprocessor: Prevent race creating new taskprocessor." into 13 2018-11-17 17:28:31 -06:00
George Joseph
73efe86436 CI: Mount a tmpfs on /tmp for testsuite docker containers
Change-Id: I0566d81b0852f22066cd76d58eae5f1fda5602aa
2018-11-17 14:40:46 -07:00
George Joseph
a335f4c9ad CI: Pass work directory to runTestsuite
The testsuite can now use a user-specified work directory for
all it's temp files.  This allows the docker containers to use
a tmpfs backed directory for the temp files instead of it's
own write-layer image.

* runTestsuite.sh now accepts a --work-dir command line argument
  that gets exported as AST_WORK_DIR before running the testsuite.

* gates.jenkinsfile now specifies --work-dir to be
  <testsuite_dir>/astroot.

Since the Asterisk CI docker hosts now mount /srv/jenkins/workspace
on a tmpfs, asterisk should be compiled and the testsuite run all in
memory.

Change-Id: If5ee905a15821296c355bb84cda38950ad8edc45
2018-11-17 12:07:32 -07:00
George Joseph
e0fbf92372 Merge "CI: Allow runUnittests to use 'expect' to run the tests" into 13 2018-11-17 11:30:12 -06:00
George Joseph
4937772a8d Merge "core: Fix handling of restart from remote console." into 13 2018-11-16 09:22:15 -06:00
George Joseph
97633c09c5 CI: Allow runUnittests to use 'expect' to run the tests
There seems to be a race condition between starting the asterisk
daemon and attempting to use 'asterisk -r' that can cause the
control socket file to not be created.  Since all of the Jenkins
slaves have 'expect' installed, the runUnittests script can use
it to start asterisk in the forground and issue the commands
interactively.  This is much more reliable and it can also make
startup errors more visible since they'll be in the Jenkins console
output.

If 'expect' isn't installed, the original daemon/asterisk -r
process is used.

Also added a "core show settings" before running the tests
and added "notice,warning,error" to the console log.

Change-Id: Idd656085f854afede813ac241b9e312b31358160
2018-11-16 08:03:25 -07:00
Corey Farrell
2f75f1941a taskprocessor: Prevent race creating new taskprocessor.
Task processors are retrieved using a 'get or create' pattern.  The
singleton container was unlocked between the get and create steps so
it's possible that two threads could create task processors with the
same name at the same time.

Change-Id: Id64fae94a6a1e940ddf38fde622dcd4391635382
2018-11-16 08:55:56 -05:00
George Joseph
4ae848e27a Merge "pbx_config: Only the first [globals] section is seen." into 13 2018-11-15 07:48:30 -06:00
Torrey Searle
da4879443b res/res_pjsip_nat: Fix logic for REINVITES
The presence of Record-Route in re-invites is optional, thus it is
important to make sure the dialog doesn't have a routset before
rewriting the contact header.

ASTERISK-28129 #close

Change-Id: Ic8ceb54ccfc93f7e315e476c514a2c777f2da7dc
2018-11-15 07:35:00 -04:00
Corey Farrell
013d0c50fb core: Fix handling of restart from remote console.
We cannot use need_el_end and SIGURG when restarting.  Instead we need
to run el_end within the SIGHUP restartnow handler.

ASTERISK-28158

Change-Id: Ia852276363c81bdcf1aa29eb4558c5c2fa1218a0
2018-11-15 06:27:51 -05:00
Joshua Colp
a40b6ad471 Merge "core: Ensure that el_end is always run when needed." into 13 2018-11-14 07:06:52 -06:00
Joshua Colp
7a562e896e Merge "taskprocessor: Do not use separate allocation for stats or name." into 13 2018-11-14 07:05:54 -06:00
George Joseph
e691f9fab2 Merge "jansson-bundled: Patch for off-nominal crash." into 13 2018-11-13 14:39:46 -06:00
Corey Farrell
dc54dc0439 taskprocessor: Do not use separate allocation for stats or name.
Merge storage for the stats object and name string into the main
allocation for struct ast_taskprocessor.

Change-Id: I74fe9a7f357f0e6d63152f163cf5eef6428218e1
2018-11-12 08:11:54 -05:00
Joshua Colp
6aea312a55 Merge "res_pjsip.c: Make taskprocessor scheduling algorithm pick the shortest queue" into 13 2018-11-12 05:38:27 -06:00
Corey Farrell
2301580ba8 core: Ensure that el_end is always run when needed.
* Ignore console=yes configuration option in remote console processes.
* Use new flag to tell consolethread to run el_end and exit when needed.

ASTERISK-28158

Change-Id: I9e23b31d4211417ddc88c6bbfd83ea4c9f3e5438
2018-11-11 09:23:04 -05:00
Corey Farrell
d4d3818ecb jansson-bundled: Patch for off-nominal crash.
pack_string crashed on non-NULL strings returned when s->has_error was
true if the string was the result of 's' format without '#', '%' or '+'.

Change-Id: Ic125df691d81ba2cbc413e37bdae657b304d20d0
2018-11-08 18:02:08 -05:00
Corey Farrell
1709f6be77 pbx_config: Only the first [globals] section is seen.
If multiple [globals] sections are used (for example via separate
included files), only the first one is processed.  This can result in
lost global variables when using a modular extensions.conf.

ASTERISK-28146 #close

Change-Id: Iaac810c0a7c4d9b1bf8989fcc041cdb910ef08a0
2018-11-08 06:43:01 -05:00
Chris-Savinovich
bc2420ee0e res_pjsip: Send a 503 response when overload state if reliable transport.
When Asterisk's taskprocessors get overloaded we need to reduce the work
load. res_pjsip currently ignores new SIP requests and relies on SIP
retransmissions in the hope that the overload condition will clear soon
enough to handle the retransmitted SIP request.
This change adds the following code after ast_taskprocessor_alert_get()
has returned TRUE:
1- identifies transport type. If non-udp then send a 503 response
2- if transport type is udp/udp6 then ignore, as before.

Change-Id: I1c230b40d43a254ea0f226b7acf9ee480a5d3836
2018-11-07 07:59:18 -05:00
Joshua Colp
2c35dfc502 Merge "stasis: Clarify lifetime of topics." into 13 2018-11-07 06:06:02 -06:00
Kevin Harwell
214d0d118a res_pjsip: formatting error in documentation
The use of a '|' in the "global/debug" synopsis documentation caused the
generated html table on the wiki to add an extra column that included the
text after the pipe.

This patch replaces the pipe with a comma.

ASTERISK-28150

Change-Id: I3d79a6ca6d733d9cb290e779438114884b98a719
2018-11-06 18:05:00 -05:00
Alexei Gradinari
158214c1a0 res_pjsip.c: Make taskprocessor scheduling algorithm pick the shortest queue
The current round-robin method does not take the current taskprocessor
load into consideration when distributing requests.  Using the least-size
method the request goes to the taskprocessor that is servicing the least
number of active tasks at the current time.

Longer running tasks with the round-robin method can delay processing
tasks.

* Change the algorithm from round-robin to least-size for picking the
PJSIP taskprocessor from the default serializer pool.

Change-Id: I7b8d8cc2c2490494f579374b6af0a4868e3a37cd
2018-11-05 17:12:25 -06:00
George Joseph
8b965c386a Merge "chan_sip: Attempt ast_do_pickup in handle_invite_replaces" into 13 2018-11-05 09:33:22 -06:00
Joshua Colp
2f8499788a stasis: Clarify lifetime of topics.
As mentioned in the comment I've added in the code there is no
ability to unsubscribe all subscribers from a topic and explicitly
destroy it. This is not currently a problem as we have two types of
topics:

Long lived topics which exist for the lifetime of the system.
Ephemeral topics which feed a long lived topic.

In the case of the ephemeral topics there is no subscriber which does
not have its lifetime managed by the same entity that has created
the topic. This ensures that when the topic is being unreferenced the
subscribers are also unsubscribed and destroyed, allowing the topic
to ultimately be destroyed as well.

Change-Id: Ic5e244da7b16b1895ba1fc5ece481ebba5809c9a
2018-11-05 14:30:54 +00:00
Jasper Hafkenscheid
cf193d53ad chan_sip: Attempt ast_do_pickup in handle_invite_replaces
When a call pickup is performed using and invite with replaces header
the ast_do_pickup method is attempted and a PICKUP stasis message is sent.

ASTERISK-28081 #close
Reported-by: Luit van Drongelen

Change-Id: Ieb1442027a3ce6ae55faca47bc095e53972f947a
2018-11-02 15:03:13 +01:00
Pascal Cadotte Michaud
0a4e8a43e3 contrib/sip_to_pjsip: add a --quiet option to avoid prints
Using the --quiet or -q option in conjonction with /dev/stdout as the output
file allow the output to be used as a valid configuration.

Given a script that generates a valid sip.conf I can pipe the output of that
script into `sip_to_pjsip.py -q /dev/stdin /dev/stdout`. This allow me to use
that piped command in my pjsip.conf using the `exec` command.

ASTERISK-28136

Change-Id: I7b0e2e90e2549f3f8e01dc96701f111b5874c88d
2018-11-01 08:38:21 -04:00
George Joseph
5605928db0 Merge "res_pjsip: Add XML documentation for "use_callerid_contact"" into 13 2018-10-31 13:59:04 -05:00
George Joseph
466607da1c Merge "alembic: Fix use_callerid_contact option add script." into 13 2018-10-31 13:58:12 -05:00
George Joseph
5567f618a9 Merge "pjsip: new endpoint's options to control Connected Line updates" into 13 2018-10-31 13:56:47 -05:00
Joshua Colp
9946bcc557 res_pjsip: Add XML documentation for "use_callerid_contact"
ASTERISK-28087

Change-Id: I69d48813ec514f5ef06c6de994cba52630e0a3b4
2018-10-31 08:22:46 -05:00
Richard Mudgett
c81ffa9ec8 alembic: Fix use_callerid_contact option add script.
ASTERISK-28087

Change-Id: I046d018015427d0916fab571b5a4f5367476f729
2018-10-30 10:52:28 -05:00
Alexei Gradinari
bfe3821800 pjsip: new endpoint's options to control Connected Line updates
This patch adds new options 'trust_connected_line' and 'send_connected_line'
to the endpoint.

The option 'trust_connected_line' is to control if connected line updates
are accepted from this endpoint.

The option 'send_connected_line' is to control if connected line updates
can be sent to this endpoint.

The default value is 'yes' for both options.

Change-Id: I16af967815efd904597ec2f033337e4333d097cd
2018-10-30 10:37:51 -05:00
Pascal Cadotte Michaud
e0472eb1d0 contrib/sip_to_pjsip: handle setvar in conversion
Given a sip.conf with the following content:

setvar FOO=1
setvar BAR=42

I want my generated pjsip.conf to containt the following set_vars

set_var FOO=1
set_var BAR=42

in the matching endpoint section.

Change-Id: I6c822401fda4133c3b44bf31e655b4eb939d4d26
2018-10-30 10:25:40 -05:00
George Joseph
0b695d1e38 Merge "res_pjsip_notify: improve realtime performance on CLI completion on the endpoint" into 13 2018-10-29 13:22:38 -05:00
Alexei Gradinari
82f0a86e39 res_pjsip_notify: improve realtime performance on CLI completion on the endpoint
The module 'res_pjsip_notify' inefficiently makes a lot of DB requests
on CLI completion on the endpoint.

For example if there are 10k endpoints the module makes 10k requests
of these 10k records.

Even if a part of the endpoint entered
the module makes the same 10k requests and then filtered them by itself.

This patch gathers endpoints container by prefix
and adds all gathered endpoints to completion at once.

ASTERISK-28137 #close

Change-Id: Ic20024912cc77bf4d3e476c4cd853293c52b254b
2018-10-26 18:15:36 -04:00
Torrey Searle
bbbec2e95e res_pjsip_session: add new flag use_callerid_contact
Add a new global flag to res_pjsip to allow the callerid to be used
as the username in the contact header.  This allows chan_pjsip to have
the same behavour as chan_sip

ASTERISK-28087 #close

Change-Id: I9a720e058323f6862a91c62f8a8c1a4b5c087b95
2018-10-26 09:39:08 +02:00
Joshua Colp
dc52719cb9 Merge "app_dial/queue/followme: 'I' options to block initial updates in both directions" into 13 2018-10-25 07:46:00 -05:00
Richard Mudgett
92f71534fd logger.c: Fix default console logging when no logger.conf available.
Default logging was not setup correctly when there was no logger.conf.
This resulted in many expected log messages not actually getting out to
the console.

Change-Id: I542e61c03b2f630ff5327f9de5641d776c6fa70c
2018-10-24 17:10:30 -05:00
George Joseph
1c33cf5cf1 Merge "astobj2: Eliminate usage of legacy container allocation macros." into 13 2018-10-24 08:30:27 -05:00
George Joseph
46e3dbf1fd Merge "app_dial/app_queue: Update application option documentation" into 13 2018-10-24 07:47:09 -05:00
George Joseph
ba97d7709d Merge "lock: Replace __ast_mutex_logger with private log_mutex_error." into 13 2018-10-24 07:45:36 -05:00
Richard Mudgett
d3d938016b Merge "Fix 'statement' typo throughout code." into 13 2018-10-22 10:25:14 -05:00
Richard Mudgett
ace9bc0db4 Merge "samples: PARKINGSLOT -> PARKING_SPACE in parking sample config" into 13 2018-10-22 10:20:43 -05:00
Corey Farrell
54a1fbe428 astobj2: Eliminate usage of legacy container allocation macros.
These macros have been documented as legacy for a long time but are
still used in new code because they exist.  Remove all references to:
* ao2_container_alloc_options
* ao2_t_container_alloc_options
* ao2_t_container_alloc

These macro's are still available for use but only in modules.  Only
ao2_container_alloc remains due to it's use in over 100 places.

Change-Id: I1a26258b5bf3deb081aaeed11a0baa175c933c7a
2018-10-19 17:32:58 -04:00
Alexei Gradinari
0e7b91a22b app_dial/queue/followme: 'I' options to block initial updates in both directions
The 'I' option currently blocks initial CONNECTEDLINE or REDIRECTING updates
from the called parties to the caller.

This patch also blocks updates in the other direction before call is
answered.

ASTERISK-27980

Change-Id: I6ce9e151a2220ce9e95aa66666933cfb9e2a4a01
2018-10-19 15:35:24 -05:00
Corey Farrell
655a962aa5 lock: Replace __ast_mutex_logger with private log_mutex_error.
__ast_mutex_logger used the variable `canlog` without accepting it as a
argument.  Replace with internal macro `log_mutex_error` which takes
canlog as the first arguement.  This will prevent confusion when working
with lock.c code, many of the function declare the canlog variable and
in some cases it previously appeared to be unused.

Change-Id: I83b372cb0654c5c18eadc512f65a57fa6c2e9853
2018-10-19 11:43:28 -05:00
George Joseph
b7cb2c90e6 Merge "taskprocessor: Warn on unused result from pushing task." into 13 2018-10-19 08:40:18 -05:00
Richard Mudgett
badf0adf86 app_dial/app_queue: Update application option documentation
* Update the post-answer documentation and example.  The Dial example was
incorrect and misleading for the post-answer subroutine useage.

* Fix note and warning paragraphs in option descriptions.  They don't show
up in the wiki.

Change-Id: I81019a1fd75d5b9151f76b52c38e2a90da682d14
2018-10-18 16:56:01 -05:00
Sean Bright
78aee0f6a2 samples: PARKINGSLOT -> PARKING_SPACE in parking sample config
PARKINGSLOT was deprecated in Asterisk 12 but the sample config was not
updated to reflect that.

Change-Id: I3e087c19d9ee587094fa5304102d8084a79c2b3c
2018-10-18 15:56:42 -04:00