Commit Graph

13806 Commits

Author SHA1 Message Date
Tilghman Lesher
bd6cde63d3 When we receive no response at all to our INVITE, allow the channel to be destroyed.
(closes issue #15627)
 Reported by: falves11
 Patches: 
       20091209__issue15627__1.6.0.diff.txt uploaded by tilghman (license 14)
       20091209__issue15627__1.4.diff.txt uploaded by tilghman (license 14)
 Tested by: falves11
Review: https://reviewboard.asterisk.org/r/446/
(closes issue #15716)
Reported by: dant
(closes issue #16270)
Reported by: corruptor
(closes issue #15356)
Reported by: falves11
(issue #16382)
Reported by: lftsy


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@234095 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-10 16:08:20 +00:00
Leif Madsen
bee22ddbec Update chan_spy documentation.
Update the documentation in ChanSpy and ExtenSpy to reflect that only a
single group can be specified to the g() option.

(closes issue #16420)
Reported by: diatonic

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@234094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-10 15:49:12 +00:00
Russell Bryant
b11d227e7e Fix breakage of the "module load <module>" CLI command.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-09 19:58:46 +00:00
Russell Bryant
4dfd9d4800 Set a module load priority for format modules.
A recent change to app_voicemail made it such that the module now assumes that
all format modules are available while processing voicemail configuration.
However, when autoloading modules, it was possible that app_voicemail was
loaded before the format modules. Since format modules don't depend on
anything, set a module load priority on them to ensure that they get loaded
first when autoloading.

This version of the patch is specific to Asterisk 1.4 and 1.6.0.  These versions
did not already support module load priority in the module API.  This adds a
trivial version of this which is just a module flag to include it in a pass before
loading "everything".

Thanks to mmichelson for the review!

(closes issue #16412)
Reported by: jiddings
Tested by: russell

Review: https://reviewboard.asterisk.org/r/445/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-09 15:14:21 +00:00
Atis Lezdins
a52e302427 Merged revisions 233577 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r233577 | atis | 2009-12-08 01:10:13 +0200 (Tue, 08 Dec 2009) | 8 lines
  
  Fix compatibility with valgrind 3.3 and older.
  
  (noticed in issue #16388)
  Reported by: parisioa
  Patches:
      valgrind.supp uloaded by atis (license 242)
  Tested by: atis, parisioa
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233618 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-08 00:02:43 +00:00
David Vossel
75b2fba708 hex escape control and non 7-bit clean characters in uri_encode
In ast_uri_encode, non 7-bit clean characters were being hex escaped
correctly, but control characters were not. 

(issue #16299)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-07 23:24:59 +00:00
David Vossel
55e6ac62e9 fixes missing Contact header angle brackets
(closes issue #16298)
Reported by: mgernoth
Patches:
      reg_parse_issue_1.4.diff uploaded by dvossel (license 671)
Tested by: dvossel



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233471 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-07 18:07:38 +00:00
Matthew Nicholson
6bf84d94b7 Allow SDP packets with only video session information.
(closes issue #16387)
Reported by: zalex1953
Tested by: mnicholson, zalex1953



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-07 16:11:16 +00:00
David Vossel
adc47c1cce clarify requirecalltoken option in iax.sample.conf
(closes issue #16223)
Reported by: bklang
Patches:
      clarify-iax-requirecalltoken.patch uploaded by bklang (license 919)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-04 21:54:01 +00:00
David Vossel
6efb416d91 document and rename strip_control() in app_voicemail
(closes issue #16291)
Reported by: wdoekes



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233116 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-04 17:21:34 +00:00
Russell Bryant
a10f93404d Only do frame payload check for HOLD frames.
This code was added for helping to debug the source of invalid HOLD frames.
However, a side effect of this is that it will incorrectly report errors for
frames that have an integer payload.  Make the check for this block specific
to the HOLD frame case.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233092 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-04 17:12:47 +00:00
Matthias Nick
2e6e7dcdc2 Parse global variables or expressions in hint extensions
Parse global variables or expressions in hint extensions. Like: exten => 400,hint,DAHDI/i2/${GLOBAL(var)}

(closes issue #16166)
Reported by: rmudgett
Tested by: mnick, rmudgett


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233091 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-04 16:59:21 +00:00
Matthias Nick
5bcec8ad6c Warning message gets displayed only once
Added additional field 'int display_inband_dtmf_warning', which when set to '1' displays the warning ('Inband DTMF is not supported on codec %s. Use RFC2833'), and when set to '0' doesn't display the warning. Otherwise you would get hundreds of warnings every second.

(closes issue #15769)
Reported by: falves11
Patches:
	patch_15769_14.txt uploaded by mnick (license 874)
Tested by: mnick, falves11



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@233014 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-04 15:17:03 +00:00
Tilghman Lesher
ca5867f707 Deprecate "cz" in favor of "cs".
Also, change the use of language codes so that language registers as a prefix,
rather than an exact match.
(closes issue #16272)
 Reported by: patrol-cz
 Patches: 
       20091203__issue16272.diff.txt uploaded by tilghman (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-03 20:10:19 +00:00
Jeff Peeler
7f062697d5 Send ack (response/message) after receiving manager action userevent
(closes issue #16264)
Reported by: dimas
Patches: 
      event-ack.patch uploaded by dimas (license 88)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 21:57:42 +00:00
David Vossel
9482a6da39 fixes app_queue ao2 error
(closes issue #16369)
Reported by: vrban
Patches:
      queue_issue_1.4.diff uploaded by dvossel (license 671)
Tested by: dvossel



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 19:03:01 +00:00
Joshua Colp
32365fe106 Fix a bug where if you hung up very quickly after calling AMD it would overwrite the AMDSTATUS of HANGUP with TOOLONG.
(closes issue #16239)
Reported by: CGMChris


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 17:04:52 +00:00
David Vossel
5c0d5badd6 ast_outaddrfor doesn't do htons() on port, looks odd in strace.
(closes issue #16290)
Reported by: wdoekes



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 16:59:18 +00:00
David Vossel
4cfef673d6 fixes segfault in func_groupcount
closes issue #16337)
Reported by: Parantido
Patches:
      issue_16337.diff uploaded by dvossel (license 671)
	  Tested by: Parantido, dvossel



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 15:41:36 +00:00
Terry Wilson
c2c8cea691 Fix compiling without devmode
(closes issue #16367)
 Reported by: falves11


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 04:05:09 +00:00
Jeff Peeler
09c3005ca6 Do not modify the gain settings on data calls.
(The digital flag actually represents a data call.)

(closes issue #15972)
Reported by: udosw
Patches: 
      transcap_digital_fix.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232090 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-02 00:42:58 +00:00
Russell Bryant
42d9c2c466 Fix a warning pointed out by buildbot.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@232007 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-01 23:25:36 +00:00
Jeff Peeler
8d6faec4b6 log channel name in dev mode as well
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231926 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-01 21:52:39 +00:00
Jeff Peeler
9405b9e2b7 Fix crash with invalid frame data
The crash was happening as a result of a frame containing an invalid data
pointer, but was set with data length of zero. The few times the issue was
reproduced it _seemed_ that the frame was queued properly, that is the data
pointer was set to NULL. I never could reproduce the crash so as a last resort
the crash has been fixed, but a check in __ast_read has been added to give as
much information about the source of problematic frames in the future.

(closes issue #16058)
Reported by: atis


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231911 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-01 21:29:31 +00:00
David Vossel
031d3b8d1f WaitExten m option with no parameters generates frame with zero datalen but non-null data ptr
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231853 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-01 21:14:31 +00:00
Matthew Nicholson
64c5037988 Ignore unknown formats in ast_format_str_reduce() and return an error if no know formats are found.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231740 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-12-01 15:34:57 +00:00
Matthew Nicholson
6a680d9b28 Remove duplicate entries from voicemail format lists. This prevents app_voicemail from entering an infinite loop when the same format is specified twice in the format list.
(closes issue #15625)
Reported by: Shagg63
Tested by: mnicholson

Review: https://reviewboard.asterisk.org/r/429/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231614 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 21:11:44 +00:00
David Vossel
4f89878b7f fixes crash caused by RTP comfort noise payload greater than 24 bytes
AST-2009-010

(closes issue #16242)
Reported by: amorsen
Patches:
      issue16242.diff uploaded by oej (license 306)
Tested by: amorsen, oej, dvossel



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231441 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 17:14:08 +00:00
David Vossel
264a1a78a9 app_queue crashes randomly, often during call-transfers
In app_queue, it is possible for a call_queue to be destroyed
while another object still holds a pointer to it.  This patch
converts call_queue objects to ao2 objects allowing them to be
ref counted.  This makes it safe for the queue_ent object in
queue_exec() to reference it's parent call_queue even after it
has left the queue.

(closes issue #15686)
Reported by: Hatrix
Patches:
      v2_queue_ao2.diff uploaded by dvossel (license 671)
Tested by: dvossel, aragon

Review: https://reviewboard.asterisk.org/r/427/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 16:32:58 +00:00
Tilghman Lesher
85cce5cb4b After a frame duplication failure, unlock the channel before returning.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-25 22:31:57 +00:00
David Vossel
c79e242ada fixes solaris segfault on dial with verbosity >= 3
(closes issue #16193)
Reported by: asgaroth
Patches:
      bug_16193_1.4.21.2_vers.diff uploaded by snuffy (license 35)
Tested by: asgaroth, snuffy



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231235 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-25 21:38:32 +00:00
David Vossel
8730e034d3 fixes conditional jump or move depending on uninitialised STACK value
(closes issue #16261)
Reported by: edguy3
Patches:
      edguy16261.patch uploaded by edguy3 (license 917)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@231233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-25 21:23:41 +00:00
Kevin P. Fleming
851de5edaa When 'sip set debug' is enabled, and the last line of an incoming SIP message
is not properly newline terminated, ensure that that line is included in the
debug output.

(part of issue #16268)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 15:31:02 +00:00
Kevin P. Fleming
afd2b5e203 Correct fix for issue #16268... the reporter's original patch was very close to correct.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230839 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 15:09:24 +00:00
Kevin P. Fleming
800a1df304 Ensure that SDP parsing does not ignore the last line of the SDP.
(closes issue #16268)
Reported by: sgimeno


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230772 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-23 14:13:56 +00:00
Matthew Nicholson
f32239bff8 Copy the peer CDR's userfield to the bridge CDR if it exists. This is necessary for the recordagentcalls option in chan_agent to store the recorded file name in the bridge CDR.
(closes issue #14590)
Reported by: msetim
Patches:
      queue_agent_userfield.patch uploaded by Laureano (license 265)
Tested by: Laureano, mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-20 20:53:06 +00:00
David Vossel
182c57ce17 fixes MixMonitor thread not exiting when StopMixMonitor is used
(closes issue #16152)
Reported by: AlexMS
Patches:
      stopmixmonitor_1.4.diff uploaded by dvossel (license 671)
Tested by: dvossel, AlexMS

Review: https://reviewboard.asterisk.org/r/424/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-19 21:22:46 +00:00
Michiel van Baak
9d6f7502ac Update copyright year in visible output. (cli)
Spotted by Stuart Henderson


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-19 16:09:51 +00:00
Kevin P. Fleming
708e058915 Correct mistaken option name in error message.
The configuration option for allowing hosts to make non-token-based calls
is 'calltokenoptional', not 'calltokenignore'. (reported on asterisk-users)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-15 17:19:06 +00:00
Joshua Colp
4950fbeebc Respect the maddr parameter in the Via header.
(closes issue #14446)
Reported by: frawd
Patches:
      via_maddr.patch uploaded by frawd (license 610)
Tested by: frawd


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230144 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 22:00:19 +00:00
Joshua Colp
607defd94a Fix a crash caused by two threads thinking they should both free the
chan_local private structure when only one should.

(closes issue #15314)
Reported by: sroberts
Patches:
      Issue15314_Move_Nulling_owner.patch uploaded by davidw (license 780)
Tested by: davidw, lottc


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@230038 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 19:44:07 +00:00
Joshua Colp
2ef94c5196 Document a limitation in the AVAILSTATUS variable from ChanIsAvail and provide
a workaround for it that does not change existing behavior.

(closes issue #14426)
Reported by: macli


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229965 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 17:19:59 +00:00
David Vossel
251f196760 fixes merging error, datastore was being freed in the wrong function.
(closes issue #16219)
Reported by: aragon



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229669 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-12 16:41:49 +00:00
David Brooks
933ad675be Solaris doesn't like NULL going to ast_log
Solaris will crash if NULL is passed to ast_log. This simple patch simply uses S_OR to
get around this.

(closes issue #15392)
Reported by: yrashk


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229498 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-11 19:46:19 +00:00
Tilghman Lesher
e04cade814 If two pattern classes start with the same digit and have the same number of characters, they will compare equal.
The example given in the issue report is that of [234] and [246], which have
these characteristics, yet they are clearly not equivalent.  The code still
uses these two characteristics, yet when the two scores compare equal, an
additional check will be done to compare all characters within the class to
verify equality.
(closes issue #15421)
 Reported by: jsmith
 Patches: 
       20091109__issue15421__2.diff.txt uploaded by tilghman (license 14)
 Tested by: jsmith, thedavidfactor


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 22:09:16 +00:00
David Ruggles
4d366f8147 Fix ExternalIVR Documentation
Remove documentation for event that doesn't function

(closes issue #16220)
Reported by: thedavidfactor
Patches:
      externalivr.txt.20091110.1622.patch uploaded by thedavidfactor (license 903)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 21:45:15 +00:00
Joshua Colp
258a49e0dc Remove broken support for direct transcoding between G.726 RFC3551 and G.726 AAL2.
On some systems the translation core would actually consider g726aal2 -> g726 -> signed linear
to be a quicker path then g726aal2 -> signed linear which exposed this problem.

(closes issue #15504)
Reported by: globalnetinc


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229281 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 20:03:14 +00:00
David Ruggles
24261d3fba Document ExternalIVR event tag collision
ExternalIVR uses the D tag for two different event types. This documents that
behavior and how to differentiate between the two cases. Also includes a minor
spelling fix and clarification

(closes issue #16211)
Reported by: thedavidfactor
Patches:
      externalivr.txt.20091109.1507.patch uploaded by thedavidfactor (license 903)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 17:23:59 +00:00
David Vossel
cbd0215153 don't crash on log message in solaris
AST-2009-006

(closes issue #16206)
Reported by: bklang
Tested by: bklang



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229167 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 17:15:57 +00:00
Matthew Nicholson
d9ef686bc3 Reverted revision 202022.
(closes issue #16175)
Reported by: paul-tg


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@229091 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-10 15:22:13 +00:00