Joshua Colp
c7d51a7fc1
Put my slinfactory changes back in.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@113009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-07 14:54:42 +00:00
Tilghman Lesher
eb930d5edd
AsyncAGI should not close the manager session on error.
...
(closes issue #12370 )
Reported by: srt
Patches:
asterisk-12370.diff uploaded by srt (license 378)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112972 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-05 13:24:12 +00:00
Terry Wilson
75c6945d92
Clean up some memory leak/ref counting issues
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112939 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-05 07:58:42 +00:00
Terry Wilson
2abff11905
Multi-line support for phoneprov
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112906 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-05 04:59:25 +00:00
Steve Murphy
f291c2af0a
Found a little problem with the sip request handling that could lead to a quick crash of asterisk, and a road to a DOS attack if left unfixed.
...
Attaching to a running asterisk with "telnet hostname 5060", I would input "something", then hit return three times, and asterisk crashes.
I traced it to handle_request_do(), which zeroes out the data (an ast_str ptr) if the string is too short.
Instead of freeing the struct and nulling the pointer, it now just resets it, because this
ast_str is expected by the calling routine to still be there after handle_request_do() returns.
This appears to fix the crash. I assume that it was introduced with ast_str's being adopted. It's a subtle and easy-to-miss sort of problem.
I also found all the places where the req.data is freed, and made sure the ptr is Nulled out as well;
no good leaving bad ptrs laying around-- I didn't need to do this, but it seemed a good thing to do...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112874 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-05 01:33:13 +00:00
Philippe Sultan
71dc6a4771
Merged revisions 112820 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112820 | phsultan | 2008-04-04 21:26:15 +0200 (Fri, 04 Apr 2008) | 1 line
Free newly allocated channel before returning
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04 19:28:49 +00:00
Philippe Sultan
db884798db
Merged revisions 112766 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112766 | phsultan | 2008-04-04 19:16:59 +0200 (Fri, 04 Apr 2008) | 7 lines
Prevent call connections when codecs don't match.
(closes issue #10604 )
Reported by: keepitcool
Patches:
branch-1.4-10604-2.diff uploaded by phsultan (license 73)
Tested by: phsultan
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04 17:32:46 +00:00
Dwayne M. Hubbard
5e6d84eb69
sleep long enough for the zaptel timer error message to display before exit
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112714 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04 00:57:33 +00:00
Joshua Colp
b7b2e732f0
Merged revisions 112711 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112711 | file | 2008-04-03 21:52:36 -0300 (Thu, 03 Apr 2008) | 2 lines
Pass in the path to Zaptel for systems that install Zaptel headers in a separate location.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04 00:53:19 +00:00
Joshua Colp
193d45aad7
Blocked revisions 112709 via svnmerge
...
........
r112709 | file | 2008-04-03 21:48:01 -0300 (Thu, 03 Apr 2008) | 2 lines
One thing at a time... let's get 1.4 building.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04 00:49:01 +00:00
Dwayne M. Hubbard
bc79fa76f6
blocked for trunk....woot
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112708 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-04 00:32:05 +00:00
Dwayne M. Hubbard
6dafddbe39
satisfy buildbot
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112656 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03 22:19:43 +00:00
Dwayne M. Hubbard
593dcbe311
add a Zaptel timer check to verify the timer is responding when Zaptel support is compiled into Asterisk and Zaptel drivers are loaded. This will help people not waste their valuable time debugging side effects.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112653 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03 22:13:11 +00:00
Mark Michelson
3fd8236d28
Merged revisions 112599 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112599 | mmichelson | 2008-04-03 09:32:20 -0500 (Thu, 03 Apr 2008) | 9 lines
Fix the testing of the "res" variable so that it is more logically correct and
makes the correct warning and debug messages print.
(closes issue #12361 )
Reported by: one47
Patches:
chan_zap_deferred_digit.patch uploaded by one47 (license 23)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03 14:35:47 +00:00
Tilghman Lesher
0e6140c564
Use a 32k file buffer on recordings, which increases the efficiency of file recording.
...
(closes issue #11962 )
Reported by: garlew
Patches:
recording.patch uploaded by garlew (license 376)
bug-11962.diff uploaded by snuffy (license 35)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112564 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-03 07:49:05 +00:00
Tilghman Lesher
cbf80c1a3c
Make MISDN generate channel rename events when the name changes.
...
(closes issue #11142 )
Reported by: julianjm
Patches:
chan_misdn_tmpchan_trunk_v1.diff uploaded by julianjm (license 99)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02 19:34:52 +00:00
Mark Michelson
2580dfc6fb
Merged revisions 112468 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112468 | mmichelson | 2008-04-02 12:36:04 -0500 (Wed, 02 Apr 2008) | 13 lines
Fix a race condition in the manager. It is possible that a new manager event
could be appended during a brief time when the manager is not waiting for input.
If an event comes during this period, we need to set an indicator that there is an
event pending so that the manager doesn't attempt to wait forever for an event that
already happened.
(closes issue #12354 )
Reported by: bamby
Patches:
manager_race_condition.diff uploaded by bamby (license 430)
(comments added by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02 17:36:49 +00:00
Joshua Colp
b5cccfe1a4
Since the SIP request structure gets reused multiple times with TCP handling we have to clear the debug state or else we will keep spitting out debug even after it has been turned off.
...
(closes issue #12169 )
Reported by: pj
Patches:
12169-debugoff-2.diff uploaded by qwell (license 4)
Tested by: pj
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02 15:26:51 +00:00
Terry Wilson
1eb31edde2
Re-add HTTP post support by moving to res_http_post.c
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112426 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02 15:25:48 +00:00
Mark Michelson
b95d24ea47
Merged revisions 112393 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112393 | mmichelson | 2008-04-02 09:32:00 -0500 (Wed, 02 Apr 2008) | 6 lines
Ensure that there is no timeout if none is specified.
(closes issue #12349 )
Reported by: johnlange
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-02 14:32:43 +00:00
Jeff Peeler
6699761f80
Added dnsmgr status output for sip show registry.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 22:55:28 +00:00
Steve Murphy
da41d47a83
Bumped across another test set for the new exten pattern matcher, which revealed a problem with the CANMATCH/MATCHMORE modes. Direct matches were getting in the way. Fixed.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112357 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 22:45:10 +00:00
Russell Bryant
094fc2c616
Fix a typo that prevented configuration of non-dynamic peers.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 22:25:45 +00:00
Jeff Peeler
e9825d7c8a
Existing DNS manager lookups extended to check for SRV records.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112321 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 22:07:30 +00:00
Steve Murphy
2fb0bfba35
(closes issue #12298 )
...
Reported by: falves11
Patches:
12298.patch1 uploaded by murf (license 17)
Tested by: murf
I have hopes that the changes made over the last few days will
finalize and solidify this code. While there are bound to be
small tweaks still needed, I feel that the job (at last) is
somewhat completed. Finally, I had a chance to comprehend how
the scoring of extension patterns was done in the previous
version, and I've come very close to using the exact same
criteria in the new pattern matching code. The left-right
sorting is now replicated in the trie structure itself, such
that the first match found will the 'best' match. Compared
the results against 1.4 for several extensions. Replicated
falves11's setup and it works. Used some devious patterns
provided by jsmith, supplemented with a few of my own.
Looks good.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112289 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 20:02:19 +00:00
Jason Parker
a734470a2b
Minor formatting cleanup.
...
(closes issue #12343 )
Reported by: travishein
Patches:
app_voicemail_code_convention.patch uploaded by travishein (license 385)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 18:27:08 +00:00
Jason Parker
9f1e663935
More voicemail doxygen additions/cleanup.
...
(issue #12343 )
Reported by: travishein
Patches:
app_voicemail_code_documentation.patch uploaded by travishein (license 385)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 18:24:56 +00:00
Tilghman Lesher
d751947b1a
Fix last commit
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 18:23:40 +00:00
Joshua Colp
0d7cfae6b6
Merged revisions 112209 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112209 | file | 2008-04-01 15:02:43 -0300 (Tue, 01 Apr 2008) | 4 lines
Disable Packet2Packet bridging when we need to feed DTMF frames into the core. Some implementations do not like how we switch between things.
(closes issue #12212 )
Reported by: bamby
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112210 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 18:06:13 +00:00
Jeff Peeler
a5cdd849e5
This adds DNS SRV record support to DNS manager. If there is a SRV record for a given domain, the hostname and port listed in the SRV record will be used. If no SRV record exists or a SRV lookup is not attempted, the DNS lookup on the specified domain will be performed as normal. Chan_sip has been modified to take advantage of the new SRV support.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 17:53:08 +00:00
Joshua Colp
a8be22f9da
Merged revisions 112204 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112204 | file | 2008-04-01 14:43:46 -0300 (Tue, 01 Apr 2008) | 4 lines
Do not pass audio until the remote side has indicated they are providing early media, or if the channel has been answered.
(closes issue #11823 )
Reported by: SDamm
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112205 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 17:48:52 +00:00
Joshua Colp
dcf4e46d8f
Demote a log message down to a warning.
...
(closes issue #12345 )
Reported by: caio1982
Patches:
limit_msg.diff uploaded by caio1982 (license 22)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112155 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 17:24:45 +00:00
Mark Michelson
4dbacf6bbc
Merged revisions 112138 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112138 | mmichelson | 2008-04-01 12:21:21 -0500 (Tue, 01 Apr 2008) | 10 lines
Initialize the __res_state structure used for dns purposes
to all 0's prior to using it. This is due to valgrind's complaints
on issue #12284 as well as an excerpt found in "Description" portion
of the online man page found here:
http://www.iti.cs.tu-bs.de/cgi-bin/UNIXhelp/man-cgi?res_nquery+3RESOLV
(pertains to issue #12284 but does not necessarily close it)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112148 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 17:23:19 +00:00
Joshua Colp
7dab892401
Merged revisions 112125 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112125 | file | 2008-04-01 13:45:14 -0300 (Tue, 01 Apr 2008) | 5 lines
Ensure that we do not exceed the hold's maximum size with a single frame.
(closes issue #12047 )
Reported by: fabianoheringer
Tested by: fabianoheringer
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 16:50:37 +00:00
Russell Bryant
af9c1ee0df
Now that zaptel trunk has been removed, add the PSTN deprecation notice to chan_zap, as well.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-04-01 16:35:04 +00:00
Jason Parker
652ce60a6f
I missed a place when this define was changed.
...
(closes issue #12334 )
Reported by: ovi
Patches:
12334-asterisk.patch uploaded by dimas (license 88)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31 22:16:34 +00:00
Jason Parker
4edaf04348
Merged revisions 112068 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r112068 | qwell | 2008-03-31 16:48:05 -0500 (Mon, 31 Mar 2008) | 5 lines
Fix a silly infinite loop when choosing an invalid option.
(closes issue #12315 )
Reported by: jmls
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31 21:48:30 +00:00
Terry Wilson
f02c11d88b
Yeah, simplify that logic a bit...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31 21:01:59 +00:00
Terry Wilson
aa720d402b
Handle blank prefix= in http.conf
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@112033 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31 20:45:05 +00:00
Russell Bryant
58f05ac8c2
Ensure configure gets run on a clean checkout.
...
(closes issue #12197 )
Reported by: juggie
Patches:
12197.diff uploaded by juggie (license 24)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31 17:14:58 +00:00
Russell Bryant
76baf34555
This fixes a high fence violation that MALLOC_DEBUG reported to me.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111996 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31 16:37:13 +00:00
Joshua Colp
e5c4deace3
Initialize all these here tmp pointers at declaration. They confused some compilers a wee bit.
...
(closes issue #12333 )
Reported by: ovi
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111961 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-31 14:20:39 +00:00
Russell Bryant
afd8783577
Make some notes about common usage of pbx_builtin_getvar_helper() that is not
...
thread-safe.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 22:50:46 +00:00
Russell Bryant
16b2720cd4
Note a minor race condition that I noticed while reviewing Jeff's changes
...
to this code.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111908 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 22:45:43 +00:00
Jason Parker
7af650c18b
Merged revisions 111856 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r111856 | qwell | 2008-03-28 16:45:35 -0500 (Fri, 28 Mar 2008) | 12 lines
Allow gsm to compile correctly on x86 with gcc4 optimizations.
(closes issue #11243 )
Reported by: whiskerp
Patches:
11243-maybe-asm.diff uploaded by qwell (license 4)
Tested by: Seggy (IRC)
Note: While I did write this patch, I would not have found this if fossil
had not reported and fixed issue #12253 . A huge thanks to him for helping
to (indirectly) find the problem here.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 21:46:02 +00:00
Mark Michelson
bf4893fdce
This time the fix is proper for issue 12284. I have tested it thoroughly and found
...
that valgrind no longer complains and that calls do complete correctly.
The fix is along the same lines as before: Make sure the final null terminator gets copied
into the new sip_request's data pointer. Without it, parse_request will read and potentially
write past the end of the string, causing potential crashes.
(closes issue #12284...for real this time!)
reported by falves11
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111811 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 20:03:16 +00:00
Mark Michelson
3a0f4cc933
Temporary revert of 111662. It's causing lots of trouble and appears to not be
...
the proper solution to the problem reported anyway.
(related to issue #12884 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 19:14:51 +00:00
Jason Parker
ed9e3ef23e
Replace magic number size from msgArray array with a define.
...
(same patch as before, I just split this part out)
(close issue #12326 )
Reported by: travishein
Patches:
app_voicemail_code_documentation.patch uploaded by travishein (license 385)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 19:08:35 +00:00
Jason Parker
1f8cb622bb
Add a bit of doxygen documentation for app_voicemail.
...
(issue #12326 )
Reported by: travishein
Patches:
app_voicemail_code_documentation.patch uploaded by travishein (license 385)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 19:06:54 +00:00
Jason Parker
5591c696a5
Merged revisions 111720 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r111720 | qwell | 2008-03-28 12:55:05 -0500 (Fri, 28 Mar 2008) | 1 line
Remove unimplemented softkeys. Prompted by issue #12325 .
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@111721 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-03-28 17:57:12 +00:00