Commit Graph

11580 Commits

Author SHA1 Message Date
Dwayne M. Hubbard
e2611d2f54 remove a race condition for the creation of recordthread's, and fix a small memory leak. This closes issue# 10636
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82286 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 20:24:24 +00:00
Tilghman Lesher
e28d1357de Working on issue #10531 exposed a rather nasty 64-bit issue on ast_mktime, so we
updated the localtime.c file from source.  Next we'll have to write ast_strptime
to match.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82285 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 20:12:06 +00:00
Russell Bryant
ef740deceb Clean up the output of "asterisk -h". This tweaks the wording and wraps lines
at 80 characters.
(closes issue #10699, seanbright)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 15:16:49 +00:00
Russell Bryant
347dce5c71 revert patch from issue #10553, as someone not using fastagi reported that this
broke their system.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 15:11:11 +00:00
Mark Michelson
39d628adcf Accidentally committed changes to app_voicemail which do NOT need to be in the 1.4 branch yet. reverting...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 14:30:13 +00:00
Mark Michelson
da18cece2c We should only initialize a realtime queue when it is allocated, not every time we access it. This prevents the members ao2_container
from being reallocated every time the queue is accessed.

I also removed a debug message I had accidentally left in on a previous commit.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 14:24:53 +00:00
Russell Bryant
3e11102ef8 Fix incorrect uses of ao2_find(). Every one of these calls was reading bogus
memory ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82267 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 22:37:17 +00:00
Joshua Colp
26623e4e1c (closes issue #10679)
Reported by: andrew
Build under dev mode when K6OPTS is enabled.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 21:41:49 +00:00
Russell Bryant
56b7a100bc Fix another missing unref of member objects. This one was pointed out by Marta.
When building the outgoing list in try_calling(), a member reference is stored
in each outgoing entry.  However, when this list got destroyed, the reference
was not released.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82263 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 20:49:34 +00:00
Steve Murphy
e84f98ea4f this change should fix issue # 10659 -- what I worry about is how many other bug reports it may generate. Hopefully, we can please the/a majority. Hopefully. We shall see. Calls not marked ANSWERED and with only one channel name will not be posted. This should eliminate the double CDR's.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 20:36:15 +00:00
Mark Michelson
4f36c859ad All instances of ao2_iterators which were just named 'i' have been renamed
to 'mem_iter' so that when refcounted queues are merged into trunk, there will be
little confusion regarding iterator names, especially when a queue and member iterator
are used in the same function.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 16:05:56 +00:00
Russell Bryant
057505c5a3 The sample dundi.conf claims support for a wildcard peer entry - [*], but the
code did not support it.  This patch makes it work.
(closes issue #10546, patch by dds, with some changes by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82250 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 16:03:42 +00:00
Christian Richter
370b3437ee fixed a hold/retrieve issue.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 16:01:27 +00:00
Russell Bryant
faad24c675 (closes issue #10553)
Reported by: juggie
Patches:
      res_agi_fgets-2.patch uploaded by juggie (license 24)
Tested by: juggie

When using fastagi, fgets() can return before a full line is read.  Add explicit
handling for the case where it gets interrupted.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 15:26:51 +00:00
Joshua Colp
f2ba32f8e9 (closes issue #10577)
Reported by: jamesgolovich
Patches:
      asterisk-dundifree.diff.txt uploaded by jamesgolovich (license 176)
Don't leak memory when unloading DUNDi.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 14:56:39 +00:00
Russell Bryant
808ed0e44e Add a couple more missing unrefs of queue member objects
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82240 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 14:34:12 +00:00
Russell Bryant
aa3a71d3bf Add a missing unref of a queue member in an error handling block
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82238 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 14:21:17 +00:00
Russell Bryant
ffa6e7123b Document why membercount can not simply be replaced by ao2_container_count()
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82236 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 14:09:43 +00:00
Russell Bryant
b8261abd0b backport astobj2 race condition fix. This function is the exact same as trunk
so it applies here as well.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-10 19:53:17 +00:00
Tilghman Lesher
4913548485 Convert struct member to use refcounts (closes issue #10199)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82155 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-10 18:02:02 +00:00
Mark Michelson
a13b91f49b Removing non-existent options from misdn configuration sample.
(closes issue #10678, reported and patched by IgorG)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82091 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-10 15:02:12 +00:00
Tilghman Lesher
2fc5a853d4 Fix inline compiles on really old compilers (who uses gcc 2.7 anymore, really?)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-09 02:35:18 +00:00
Russell Bryant
827ca97872 Fix a small memory leak. ast_unregister_atexit() did not free the entry it removed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81997 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-08 18:41:32 +00:00
Russell Bryant
fab2578b02 (closes issue #10672)
Bump the cleancount so that a "make clean" will be forced.  This is needed
because my fix in revision 81599 made a change to a data structure in file.h,
and since file dependency tracking is only on with dev-mode enabled, file
format modules that don't get rebuilt may crash, as is the case with this issue.

This makes me wonder - how much faster does the code build without the file
dependency tracking enabled?  If it doesn't make much of a difference, then it
may be worth just keeping it on all of the time, or perhaps just not in release
tarballs, so that this type of issue is avoided.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81952 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-08 13:42:26 +00:00
Jason Parker
d73c04d892 Allow the MEMBERINTERFACE variable to be used as the mixmonitor filename.
This moves the setting of the MEMBERINTERFACE variable to before mixmonitor.

Issue 10671, patch by sim.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-07 19:48:00 +00:00
Mark Michelson
a9b17b231c Moving the explanation for joinempty to a more appropriate place
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-07 15:25:19 +00:00
Russell Bryant
f6212e48cb (closes issue #9724, closes issue #10374)
Reported by: kenw
Patches:
      9724.txt uploaded by russell (license 2)
Tested by: kenw, russell

Resolve a deadlock that occurs when doing a SIP transfer to parking.  

I come across this type of deadlock fairly often it seems.  It is very important
to mind the boundary between the channel driver and the core in respect to the
channel lock and the channel-pvt lock.  Channel drivers lock to lock the
pvt and then the channel once it calls into the core, while the core will do
it in the opposite order.  The way this is avoided is by having channel drivers
either release their pvt lock while calling into the core, or such as in this
case, unlocking the pvt just long enough to acquire the channel lock.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 22:28:57 +00:00
Jason Parker
cd304a0a76 We added COPTS for ASTCFLAGS additions, but not LDOPTS for ASTLDFLAGS. This adds LDOPTS
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81826 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 22:05:02 +00:00
Jason Parker
82c701b0eb This should fix a build issue that people building against uClibc were seeing with the addition of astobj2
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81778 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 19:59:07 +00:00
Joshua Colp
e73fa2ba6f (closes issue #10122)
Reported by: stevefeinstein
Patches:
      meetme-unmute-manager.diff uploaded by qwell (license 4)
Tested by: stevefeinstein
After looking over the code I agree with Qwell. Setting the file descriptor to conference each time just causes a fight back and forth.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81776 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 19:40:37 +00:00
Philippe Sultan
8e10babcbd Various string length fixes. Removed an unused variable in aji_client structure (context)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81743 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 16:56:29 +00:00
Mark Michelson
76ffc54255 Fixes an issue where valid DTMF had to be pressed twice to exit a queue if a member's phone
was ringing.

(closes issue #10655, reported by strider2k, patched by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81713 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 16:25:40 +00:00
Mark Michelson
2a3b64bf70 Fixes a memory leak
(closes issue #10658, reported and patched by Ivan)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 15:20:36 +00:00
Philippe Sultan
022b5c1696 According to both RFC 3920 - section 9.1.2 - and Google's XMPP server
complaint, if set, the 'from' attribute must be set to the user's full
JID.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 14:20:54 +00:00
Russell Bryant
aa3b7e22f5 Fix an issue that can occur when you do an attended transfer to parking. If
you complete the transfer before the announcement of the parking spot finishes,
then the channel being parked will hear the remainder of the announcement.
These changes make it so that will not happen anymore.

Basically, res_features sets a flag on the channel is playing the announcement
to so that the file streaming core knows that it needs to watch out for a
channel masquerade, and if it occurs, to abort the announcement.

(closes BE-182)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81599 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 20:53:41 +00:00
Tilghman Lesher
f0cf18cc75 Solaris x86 compatibility fix
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81569 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 17:18:24 +00:00
Mark Michelson
fbbf1e2056 Fixing the build...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 15:19:47 +00:00
Jason Parker
5422814fa3 Do not try to unregister a NULL channel tech.
Also changed load_module function to use defines rather than numbers for return values.

Issue 10651, patch by rbraun_proformatique, with additions by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81523 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 15:14:30 +00:00
Mark Michelson
f5cc747662 Reverting behavior of QUEUE_MEMBER_COUNT to only count members who are logged in
and available.

(related to issue #10652, reported by wuwu)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 15:03:22 +00:00
Joshua Colp
0f82a9bbf1 (closes issue #10650)
Reported by: tacvbo
Only print out that the spy was removed while holding the spy lock.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 13:11:48 +00:00
Jason Parker
e805ee3d40 Rather than attempt to play a file, we can just check whether it exists.
Issue 10634, patch by me, testing by pabelanger, sanity checked by bweschke


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81455 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 20:54:51 +00:00
Jason Parker
ae2ccdf0ed Change default followme config file to point to the correct files.
Issue 10644, patch by pabelanger


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81453 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 19:56:06 +00:00
Russell Bryant
c95389856a Remove the typedefs on ao2_container and ao2_iterator. This is simply because
we don't typedef objects anywhere else in Asterisk, so we might as well make
this follow the same convention.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81448 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 18:37:44 +00:00
Kevin P. Fleming
0e39aced3c there is no point in sending 401 Unauthorized to a UAS that sent us a properly-formatted Authentication header with the expected username and nonce but an incorrect response (which indicates the shared secret does not match)... instead, let's send 403 Forbidden so that the UAS doesn't retry with the same authentication credentials repeatedly
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81442 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 16:40:39 +00:00
Joshua Colp
95db093c40 (closes issue #10632)
Reported by: jamesgolovich
Patches:
      asterisk-iaxfirmwareleak.diff.txt uploaded by jamesgolovich (license 176)
Fix memory leak when unloading chan_iax2. The firmware files were not being freed.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81439 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 14:23:18 +00:00
Joshua Colp
63669c4496 (closes issue #10476)
Reported by: mdu113
Only look for the end of a digit when waiting for a digit. This in turn disables emulation in the core.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 13:46:23 +00:00
Joshua Colp
7e7eef085c (closes issue #10610)
Reported by: john
Patches:
      dns.c.patch uploaded by john (license 218)
Tested by: mvanbaak
Don't return a match if no SRV record actually exists.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81435 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-04 13:10:56 +00:00
Russell Bryant
52a37f77c7 Remove a couple of calls to ast_string_field_free_pools() on peers in error
handling blocks in the code for building peers.  The peer object destructor
does this and doing it twice will cause a crash.
(closes issue #10625, reported by and patched by pnlarsson)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-03 18:57:53 +00:00
Mark Michelson
6ed2b5c1b2 Changed a comment to be more accurate.
(really this is just a test to make sure I can commit properly from home)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-01 15:57:31 +00:00
Mark Michelson
e0b90d3b06 Making match_by_addr into ao2_match_by_addr and making it available
everywhere since it could be a handy callback to have



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81426 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-01 06:02:06 +00:00