kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-06-05 13:52:23 +00:00
Code Issues Projects Releases Wiki Activity

Do some code cleanup courtesy of Mago.

Browse Source
This commit is contained in:
James Cole
2026-01-13 05:14:58 +01:00
parent 1d41fc9845
commit ebd7dca6a9
7 changed files with 12 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/Bill/ShowController.php
View File

@@ -185,7 +185,7 @@ class ShowController extends Controller
/** @var AttachmentTransformer $transformer */
$transformer = app(AttachmentTransformer::class);
$attachments = $collection->each(
static fn (Attachment $attachment) => $transformer->transform($attachment)
$transformer->transform(...)
);
}

2
app/Jobs/CreateRecurringTransactions.php
View File

@@ -157,7 +157,7 @@ class CreateRecurringTransactions implements ShouldQueue
private function filterRecurrences(Collection $recurrences): Collection
{
return $recurrences->filter(
fn (Recurrence $recurrence): bool => $this->validRecurrence($recurrence)
$this->validRecurrence(...)
);
}

4
app/Models/AvailableBudget.php
View File

@@ -103,7 +103,7 @@ class AvailableBudget extends Model
protected function endDate(): Attribute
{
return Attribute::make(
get: static fn (string $value): Carbon => Carbon::parse($value),
get: Carbon::parse(...),
set: static fn (Carbon $value): string => $value->format('Y-m-d'),
);
}
@@ -111,7 +111,7 @@ class AvailableBudget extends Model
protected function startDate(): Attribute
{
return Attribute::make(
get: static fn (string $value): Carbon => Carbon::parse($value),
get: Carbon::parse(...),
set: static fn (Carbon $value): string => $value->format('Y-m-d'),
);
}

11
app/Providers/SearchServiceProvider.php
View File

@@ -49,16 +49,7 @@ class SearchServiceProvider extends ServiceProvider
public function register(): void
{
$this->app->bind(
static function (): QueryParserInterface {
return app(QueryParser::class);
// 2025-12-20 ignore this setting.
// $implementation = config('search.query_parser');
//
// return match ($implementation) {
// 'new' => app(QueryParser::class),
// default => app(GdbotsQueryParser::class),
// };
}
static fn (): QueryParserInterface => app(QueryParser::class)
);
$this->app->bind(

6
app/Support/Twig/General.php
View File

@@ -392,7 +392,7 @@ class General extends AbstractExtension
{
return new TwigFunction(
'phpdate',
static fn (string $str): string => date($str)
date(...)
);
}
@@ -400,9 +400,7 @@ class General extends AbstractExtension
{
return new TwigFunction(
'fireflyiiiconfig',
static function (string $string, mixed $default): mixed {
return FireflyConfig::get($string, $default)->data;
}
static fn (string $string, mixed $default): mixed => FireflyConfig::get($string, $default)->data
);
}
}

8
app/Transformers/TransactionGroupTransformer.php
View File

@@ -425,9 +425,7 @@ class TransactionGroupTransformer extends AbstractTransformer
private function getSourceTransaction(TransactionJournal $journal): Transaction
{
$result = $journal->transactions->first(
static function (Transaction $transaction): bool {
return (float) $transaction->amount < 0; // lame but it works.
}
static fn (Transaction $transaction): bool => (float) $transaction->amount < 0
);
if (null === $result) {
throw new FireflyException(sprintf('Journal #%d unexpectedly has no source transaction.', $journal->id));
@@ -442,9 +440,7 @@ class TransactionGroupTransformer extends AbstractTransformer
private function getDestinationTransaction(TransactionJournal $journal): Transaction
{
$result = $journal->transactions->first(
static function (Transaction $transaction): bool {
return (float) $transaction->amount > 0; // lame but it works
}
static fn (Transaction $transaction): bool => (float) $transaction->amount > 0
);
if (null === $result) {
throw new FireflyException(sprintf('Journal #%d unexpectedly has no destination transaction.', $journal->id));

3
database/seeders/WebhookDataSeeder.php
View File

@@ -1,5 +1,8 @@
<?php
declare(strict_types=1);
/*
* WebhookDataSeeder.php