kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-10-31 18:54:58 +00:00
Code Issues Projects Releases Wiki Activity

Implement piggy bank API.

Browse Source
This commit is contained in:
James Cole
2018-06-29 08:06:17 +02:00
parent 12a84572e2
commit f048e943f8
3 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/Api/V1/Controllers/PiggyBankController.php
View File

@@ -160,14 +160,22 @@ class PiggyBankController extends Controller
}
/**
* @param Request $request
* @param string $object
* @param PiggyBankRequest $request
* @param PiggyBank $piggyBank
*
* @return JsonResponse
*/
public function update(Request $request, string $object): JsonResponse
public function update(PiggyBankRequest $request, PiggyBank $piggyBank): JsonResponse
{
// todo replace code and replace request object.
$data = $request->getAll();
$budget = $this->repository->update($piggyBank, $data);
$manager = new Manager();
$baseUrl = $request->getSchemeAndHttpHost() . '/api/v1';
$manager->setSerializer(new JsonApiSerializer($baseUrl));
$resource = new Item($budget, new PiggyBankTransformer($this->parameters), 'piggy_banks');
return response()->json($manager->createData($resource)->toArray())->header('Content-Type', 'application/vnd.api+json');
}
}

4
app/Api/V1/Requests/PiggyBankRequest.php
View File

@@ -78,8 +78,8 @@ class PiggyBankRequest extends Request
case 'PUT':
case 'PATCH':
/** @var PiggyBank $piggyBank */
$piggyBank = $this->route()->parameter('piggyBank');
$rules['name'] = 'required|between:1,255|uniquePiggyBankForUser:' . $piggyBank->id;
$piggyBank = $this->route()->parameter('piggyBank');
$rules['name'] = 'required|between:1,255|uniquePiggyBankForUser:' . $piggyBank->id;
break;
}

8
app/Repositories/PiggyBank/PiggyBankRepository.php
View File

@@ -478,7 +478,7 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
/** @var PiggyBank $piggyBank */
$piggyBank = PiggyBank::create($data);
$this->updateNote($piggyBank, $data['note']);
$this->updateNote($piggyBank, $data['note']); // todo rename to 'notes'
// repetition is auto created.
$repetition = $this->getRepetition($piggyBank);
@@ -500,9 +500,9 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
{
$piggyBank->name = $data['name'];
$piggyBank->account_id = (int)$data['account_id'];
$piggyBank->targetamount = round($data['targetamount'], 2);
$piggyBank->targetdate = $data['targetdate'];
$piggyBank->startdate = $data['startdate'];
$piggyBank->targetamount = $data['targetamount'];
$piggyBank->targetdate = $data['targetdate'] ?? $piggyBank->targetdate;
$piggyBank->startdate = $data['startdate'] ?? $piggyBank->startdate;
$piggyBank->save();