Merge branch 'release/5.1.1'

5.1.0

.deploy/heroku/.locales

@@ -15,3 +15,4 @@ el_GR
 sv_SE
 zh-hans_CN
 zh-hant_CN
+fi_FI

.env.example

@@ -15,9 +15,16 @@ SITE_OWNER=mail@example.com
 # If you use Docker or similar, you can set this variable from a file by using APP_KEY_FILE
 APP_KEY=SomeRandomStringOf32CharsExactly
 
+#
+# Firefly III will launch using this language (for new users and unauthenticated visitors)
+# For a list of available languages: https://github.com/firefly-iii/firefly-iii/tree/master/resources/lang
+#
+# If text is still in English, remember that not everything may have been translated.
+DEFAULT_LANGUAGE=en_US
 
 # Change this value to your preferred time zone.
 # Example: Europe/Amsterdam
+# For a list of supported time zones, see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
 TZ=Europe/Amsterdam
 
 # This variable must match your installation's external address but keep in mind that
@@ -48,6 +55,7 @@ APP_LOG_LEVEL=notice
 # Database credentials. Make sure the database exists. I recommend a dedicated user for Firefly III
 # For other database types, please see the FAQ: https://docs.firefly-iii.org/support/faq
 # If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+# Use "mysql" for MySQL and MariaDB. Use "sqlite" for SQLite.
 DB_CONNECTION=pgsql
 DB_HOST=firefly_iii_db
 DB_PORT=5432
@@ -73,7 +81,8 @@ SESSION_DRIVER=file
 REDIS_HOST=127.0.0.1
 REDIS_PASSWORD=null
 REDIS_PORT=6379
-REDIS_DB="0" # always use quotes
+# always use quotes and make sure redis db "0" and "1" exists. Otherwise change accordingly.
+REDIS_DB="0"
 REDIS_CACHE_DB="1"
 
 # Cookie settings. Should not be necessary to change these.
@@ -206,6 +215,11 @@ DISABLE_CSP_HEADER=false
 TRACKER_SITE_ID=
 TRACKER_URL=
 
+#
+# Firefly III could (in the future) collect telemetry on how you use Firefly III.
+# In order to allow this, change the following variable to true:
+SEND_TELEMETRY=false
+
 # You can fine tune the start-up of a Docker container by editing these environment variables.
 # Use this at your own risk. Disabling certain checks and features may result in lost of inconsistent data.
 # However if you know what you're doing you can significantly speed up container start times.

.github/code_of_conduct.md

@@ -34,7 +34,7 @@ This Code of Conduct applies both within project spaces and in public spaces whe
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at thegrumpydictator@gmail.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at james@firefly-iii.org. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
 
 Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
 

.github/contributing.md

@@ -4,7 +4,7 @@
 
 ## Feature requests
 
-I am always interested in expanding Firefly III's many features. Just open a ticket or [drop me a line](mailto:thegrumpydictator@gmail.com).
+I am always interested in expanding Firefly III's many features. Just open a ticket or [drop me a line](mailto:james@firefly-iii.org).
 
 ## Pull requests
 

.github/security.md

@@ -6,7 +6,7 @@ Only the latest version of Firefly III is supported. If you're not running the l
 
 ## Reporting a Vulnerability
 
-If you find something that compromises the security of Firefly III, you should [send me a message](mailto:thegrumpydictator@gmail.com) as soon as possible. These issues will be fixed immediately. You can also open an issue, but if you feel the issue is sensitive, please drop me a message instead.
+If you find something that compromises the security of Firefly III, you should [send me a message](mailto:james@firefly-iii.org) as soon as possible. These issues will be fixed immediately. You can also open an issue, but if you feel the issue is sensitive, please drop me a message instead.
 
 You can use my [GPG key](https://keybase.io/jc5) for extra security. My [GitHub commits](https://github.com/firefly-iii/firefly-iii/commits/master) are almost always signed with this key.
 

app/Api/V1/Controllers/Chart/CategoryController.php

@@ -90,12 +90,12 @@ class CategoryController extends Controller
         $tempData      = [];
         $spentWith     = $this->opsRepository->listExpenses($start, $end);
         $earnedWith    = $this->opsRepository->listIncome($start, $end);
-        $spentWithout  = $this->noCatRepository->listExpenses($start, $end);
-        $earnedWithout = $this->noCatRepository->listIncome($start, $end);
+        $spentWithout  = $this->noCatRepository->listExpenses($start, $end); // refactored
+        $earnedWithout = $this->noCatRepository->listIncome($start, $end); // refactored
         $categories    = [];
 
 
-        foreach ([$spentWith, $earnedWith] as $set) {
+        foreach ([$spentWith, $earnedWith, $spentWithout, $earnedWithout] as $set) {
             foreach ($set as $currency) {
                 foreach ($currency['categories'] as $category) {
                     $categories[] = $category['name'];
@@ -141,48 +141,48 @@ class CategoryController extends Controller
             }
         }
 
-        foreach ([$spentWithout, $earnedWithout] as $set) {
-            foreach ($set as $currency) {
-                $inKey        = sprintf('%d-i', $currency['currency_id']);
-                $outKey       = sprintf('%d-e', $currency['currency_id']);
-                $categories[] = (string)trans('firefly.no_category');
-                // make data arrays if not yet present.
-                $tempData[$inKey]  = $tempData[$inKey] ?? [
-                        'currency_id'             => $currency['currency_id'],
-                        'label'                   => (string)trans('firefly.box_earned_in_currency', ['currency' => $currency['currency_name']]),
-                        'currency_code'           => $currency['currency_code'],
-                        'currency_symbol'         => $currency['currency_symbol'],
-                        'currency_decimal_places' => $currency['currency_decimal_places'],
-                        'type'                    => 'bar', // line, area or bar
-                        'yAxisID'                 => 0, // 0, 1, 2
-                        'entries'                 => [
-                            // per category:
-                            // "category" => 5,
-                        ],
-                    ];
-                $tempData[$outKey] = $tempData[$outKey] ?? [
-                        'currency_id'             => $currency['currency_id'],
-                        'label'                   => (string)trans('firefly.box_spent_in_currency', ['currency' => $currency['currency_name']]),
-                        'currency_code'           => $currency['currency_code'],
-                        'currency_symbol'         => $currency['currency_symbol'],
-                        'currency_decimal_places' => $currency['currency_decimal_places'],
-                        'type'                    => 'bar', // line, area or bar
-                        'yAxisID'                 => 0, // 0, 1, 2
-                        'entries'                 => [
-                            // per category:
-                            // "category" => 5,
-                        ],
-                    ];
-                foreach ($currency['transaction_journals'] as $journal) {
-                    // is it expense or income?
-                    $letter                                  = -1 === bccomp($journal['amount'], '0') ? 'e' : 'i';
-                    $currentKey                              = sprintf('%d-%s', $currency['currency_id'], $letter);
-                    $name                                    = (string)trans('firefly.no_category');
-                    $tempData[$currentKey]['entries'][$name] = $tempData[$currentKey]['entries'][$name] ?? '0';
-                    $tempData[$currentKey]['entries'][$name] = bcadd($tempData[$currentKey]['entries'][$name], $journal['amount']);
-                }
-            }
-        }
+//        foreach ([] as $set) {
+//            foreach ($set as $currency) {
+//                $inKey        = sprintf('%d-i', $currency['currency_id']);
+//                $outKey       = sprintf('%d-e', $currency['currency_id']);
+//                $categories[] = (string)trans('firefly.no_category');
+//                // make data arrays if not yet present.
+//                $tempData[$inKey]  = $tempData[$inKey] ?? [
+//                        'currency_id'             => $currency['currency_id'],
+//                        'label'                   => (string)trans('firefly.box_earned_in_currency', ['currency' => $currency['currency_name']]),
+//                        'currency_code'           => $currency['currency_code'],
+//                        'currency_symbol'         => $currency['currency_symbol'],
+//                        'currency_decimal_places' => $currency['currency_decimal_places'],
+//                        'type'                    => 'bar', // line, area or bar
+//                        'yAxisID'                 => 0, // 0, 1, 2
+//                        'entries'                 => [
+//                            // per category:
+//                            // "category" => 5,
+//                        ],
+//                    ];
+//                $tempData[$outKey] = $tempData[$outKey] ?? [
+//                        'currency_id'             => $currency['currency_id'],
+//                        'label'                   => (string)trans('firefly.box_spent_in_currency', ['currency' => $currency['currency_name']]),
+//                        'currency_code'           => $currency['currency_code'],
+//                        'currency_symbol'         => $currency['currency_symbol'],
+//                        'currency_decimal_places' => $currency['currency_decimal_places'],
+//                        'type'                    => 'bar', // line, area or bar
+//                        'yAxisID'                 => 0, // 0, 1, 2
+//                        'entries'                 => [
+//                            // per category:
+//                            // "category" => 5,
+//                        ],
+//                    ];
+//                foreach ($currency['transaction_journals'] as $journal) {
+//                    // is it expense or income?
+//                    $letter                                  = -1 === bccomp($journal['amount'], '0') ? 'e' : 'i';
+//                    $currentKey                              = sprintf('%d-%s', $currency['currency_id'], $letter);
+//                    $name                                    = (string)trans('firefly.no_category');
+//                    $tempData[$currentKey]['entries'][$name] = $tempData[$currentKey]['entries'][$name] ?? '0';
+//                    $tempData[$currentKey]['entries'][$name] = bcadd($tempData[$currentKey]['entries'][$name], $journal['amount']);
+//                }
+//            }
+//        }
 
         // re-sort every spent array and add 0 for missing entries.
         foreach ($tempData as $index => $set) {

app/Api/V1/Controllers/CurrencyController.php

@@ -318,6 +318,10 @@ class CurrencyController extends Controller
         if ($this->repository->currencyInUse($currency)) {
             throw new FireflyException('200006: Currency in use.'); // @codeCoverageIgnore
         }
+        if ($this->repository->isFallbackCurrency($currency)) {
+            throw new FireflyException('200026: Currency is fallback.'); // @codeCoverageIgnore
+        }
+
         $this->repository->destroy($currency);
 
         return response()->json([], 204);

app/Api/V1/Controllers/Search/AccountController.php

@@ -32,6 +32,7 @@ use Illuminate\Http\Response;
 use Illuminate\Pagination\LengthAwarePaginator;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
+use Log;
 
 /**
  * Class AccountController
@@ -62,6 +63,7 @@ class AccountController extends Controller
      */
     public function search(Request $request)
     {
+        Log::debug('Now in account search()');
         $manager = $this->getManager();
         $query   = $request->get('query');
         $field   = $request->get('field');
@@ -70,6 +72,8 @@ class AccountController extends Controller
             return response(null, 422);
         }
         $types = $this->mapAccountTypes($type);
+        Log::debug(sprintf('Going to search for "%s" in types', $query), $types);
+
         /** @var AccountSearch $search */
         $search = app(AccountSearch::class);
         $search->setUser(auth()->user());
@@ -79,6 +83,8 @@ class AccountController extends Controller
 
         $accounts = $search->search();
 
+        Log::debug(sprintf('Found %d accounts', $accounts->count()));
+
         /** @var AccountTransformer $transformer */
         $transformer = app(AccountTransformer::class);
         $transformer->setParameters($this->parameters);

app/Api/V1/Controllers/TransactionController.php

@@ -29,6 +29,7 @@ use FireflyIII\Api\V1\Requests\TransactionUpdateRequest;
 use FireflyIII\Events\StoredTransactionGroup;
 use FireflyIII\Events\UpdatedTransactionGroup;
 use FireflyIII\Exceptions\DuplicateTransactionException;
+use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\TransactionGroup;
 use FireflyIII\Models\TransactionJournal;
@@ -274,6 +275,7 @@ class TransactionController extends Controller
      */
     public function store(TransactionStoreRequest $request): JsonResponse
     {
+        Log::debug('Now in API TransactionController::store()');
         $data         = $request->getAll();
         $data['user'] = auth()->user()->id;
 
@@ -283,6 +285,7 @@ class TransactionController extends Controller
         try {
             $transactionGroup = $this->groupRepository->store($data);
         } catch (DuplicateTransactionException $e) {
+            Log::warning('Caught a duplicate. Return error message.');
             // return bad validation message.
             // TODO use Laravel's internal validation thing to do this.
             $response = [
@@ -293,9 +296,22 @@ class TransactionController extends Controller
             ];
 
             return response()->json($response, 422);
-        }
+        } catch(FireflyException $e) {
+            Log::warning('Caught an exception. Return error message.');
+            Log::error($e->getMessage());
+            // return bad validation message.
+            // TODO use Laravel's internal validation thing to do this.
+            $response = [
+                'message' => 'The given data was invalid.',
+                'errors'  => [
+                    'transactions.0.description' => [sprintf('Internal exception: %s',$e->getMessage())],
+                ],
+            ];
 
-        event(new StoredTransactionGroup($transactionGroup));
+            return response()->json($response, 422);
+        }
+        app('preferences')->mark();
+        event(new StoredTransactionGroup($transactionGroup, $data['apply_rules'] ?? true));
 
         $manager = $this->getManager();
         /** @var User $admin */
@@ -338,7 +354,8 @@ class TransactionController extends Controller
         $transactionGroup = $this->groupRepository->update($transactionGroup, $data);
         $manager          = $this->getManager();
 
-        event(new UpdatedTransactionGroup($transactionGroup));
+        app('preferences')->mark();
+        event(new UpdatedTransactionGroup($transactionGroup, $data['apply_rules'] ?? true));
 
         /** @var User $admin */
         $admin = auth()->user();

app/Api/V1/Requests/AttachmentStoreRequest.php

@@ -57,8 +57,8 @@ class AttachmentStoreRequest extends Request
             'filename' => $this->string('filename'),
             'title'    => $this->string('title'),
             'notes'    => $this->nlString('notes'),
-            'model'    => $this->string('model'),
-            'model_id' => $this->integer('model_id'),
+            'model'    => $this->string('attachable_type'),
+            'model_id' => $this->integer('attachable_id'),
         ];
     }
 
@@ -77,14 +77,14 @@ class AttachmentStoreRequest extends Request
                 str_replace('FireflyIII\\Models\\', '', TransactionJournal::class),
             ]
         );
-        $model  = $this->string('model');
+        $model  = $this->string('attachable_type');
 
         return [
-            'filename' => 'required|between:1,255',
-            'title'    => 'between:1,255',
-            'notes'    => 'between:1,65000',
-            'model'    => sprintf('required|in:%s', $models),
-            'model_id' => ['required', 'numeric', new IsValidAttachmentModel($model)],
+            'filename'        => 'required|between:1,255',
+            'title'           => 'between:1,255',
+            'notes'           => 'between:1,65000',
+            'attachable_type' => sprintf('required|in:%s', $models),
+            'attachable_id'   => ['required', 'numeric', new IsValidAttachmentModel($model)],
         ];
     }
 }

app/Api/V1/Requests/AttachmentUpdateRequest.php

@@ -52,8 +52,8 @@ class AttachmentUpdateRequest extends Request
             'filename' => $this->string('filename'),
             'title'    => $this->string('title'),
             'notes'    => $this->nlString('notes'),
-            'model'    => $this->string('model'),
-            'model_id' => $this->integer('model_id'),
+            'model'    => $this->string('attachable_type'),
+            'model_id' => $this->integer('attachable_id'),
         ];
     }
 

app/Api/V1/Requests/TransactionStoreRequest.php

@@ -30,7 +30,7 @@ use FireflyIII\Rules\IsDateOrTime;
 use FireflyIII\Support\NullArrayObject;
 use FireflyIII\Validation\TransactionValidation;
 use Illuminate\Validation\Validator;
-
+use Log;
 
 /**
  * Class TransactionStoreRequest
@@ -46,6 +46,8 @@ class TransactionStoreRequest extends Request
      */
     public function authorize(): bool
     {
+        Log::debug('Authorize TransactionStoreRequest');
+
         // Only allow authenticated users
         return auth()->check();
     }
@@ -57,9 +59,11 @@ class TransactionStoreRequest extends Request
      */
     public function getAll(): array
     {
+        Log::debug('get all data in TransactionStoreRequest');
         $data = [
             'group_title'             => $this->string('group_title'),
             'error_if_duplicate_hash' => $this->boolean('error_if_duplicate_hash'),
+            'apply_rules'             => $this->boolean('apply_rules', true),
             'transactions'            => $this->getTransactionData(),
         ];
 
@@ -73,10 +77,12 @@ class TransactionStoreRequest extends Request
      */
     public function rules(): array
     {
+        Log::debug('Collect rules of TransactionStoreRequest');
         $rules = [
             // basic fields for group:
             'group_title'                          => 'between:1,1000|nullable',
             'error_if_duplicate_hash'              => [new IsBoolean],
+            'apply_rules'                          => [new IsBoolean],
 
             // transaction rules (in array for splits):
             'transactions.*.type'                  => 'required|in:withdrawal,deposit,transfer,opening-balance,reconciliation',
@@ -260,11 +266,11 @@ class TransactionStoreRequest extends Request
                 'tags'                  => $this->arrayFromValue($object['tags']),
 
                 // all custom fields:
-                'internal_reference'    => $this->stringFromValue($object['internal_reference']),
-                'external_id'           => $this->stringFromValue($object['external_id']),
+                'internal_reference'    => $this->stringFromValue((string)$object['internal_reference']),
+                'external_id'           => $this->stringFromValue((string)$object['external_id']),
                 'original_source'       => sprintf('ff3-v%s|api-v%s', config('firefly.version'), config('firefly.api_version')),
                 'recurrence_id'         => $this->integerFromValue($object['recurrence_id']),
-                'bunq_payment_id'       => $this->stringFromValue($object['bunq_payment_id']),
+                'bunq_payment_id'       => $this->stringFromValue((string)$object['bunq_payment_id']),
 
                 'sepa_cc'       => $this->stringFromValue($object['sepa_cc']),
                 'sepa_ct_op'    => $this->stringFromValue($object['sepa_ct_op']),

app/Api/V1/Requests/TransactionUpdateRequest.php

@@ -138,6 +138,7 @@ class TransactionUpdateRequest extends Request
 
         $data = [
             'transactions' => $this->getTransactionData(),
+            'apply_rules'  => $this->boolean('apply_rules', true),
         ];
         if ($this->has('group_title')) {
             $data['group_title'] = $this->string('group_title');
@@ -156,6 +157,7 @@ class TransactionUpdateRequest extends Request
         $rules = [
             // basic fields for group:
             'group_title'                          => 'between:1,1000',
+            'apply_rules'                          => [new IsBoolean],
 
             // transaction rules (in array for splits):
             'transactions.*.type'                  => 'in:withdrawal,deposit,transfer,opening-balance,reconciliation',

app/Console/Commands/Correction/FixUnevenAmount.php

@@ -90,11 +90,40 @@ class FixUnevenAmount extends Command
         }
         /** @var Transaction $source */
         $source = $journal->transactions()->where('amount', '<', 0)->first();
+
+        if (null === $source) {
+            $this->error(
+                sprintf(
+                    'Journal #%d ("%s") has no source transaction. It will be deleted to maintain database consistency.', $journal->id ?? 0,
+                    $journal->description ?? ''
+                )
+            );
+            Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete();
+            TransactionJournal::where('id', $journal->description ?? 0)->forceDelete();
+
+            return;
+        }
+
         $amount = bcmul('-1', (string)$source->amount);
 
         // fix amount of destination:
         /** @var Transaction $destination */
-        $destination         = $journal->transactions()->where('amount', '>', 0)->first();
+        $destination = $journal->transactions()->where('amount', '>', 0)->first();
+
+        if (null === $destination) {
+            $this->error(
+                sprintf(
+                    'Journal #%d ("%s") has no destination transaction. It will be deleted to maintain database consistency.', $journal->id ?? 0,
+                    $journal->description ?? ''
+                )
+            );
+
+            Transaction::where('transaction_journal_id', $journal->id ?? 0)->forceDelete();
+            TransactionJournal::where('id', $journal->description ?? 0)->forceDelete();
+
+            return;
+        }
+
         $destination->amount = $amount;
         $destination->save();
 

app/Console/Commands/CreateDatabase.php

@@ -55,10 +55,11 @@ class CreateDatabase extends Command
     {
         if ('mysql' !== env('DB_CONNECTION')) {
             $this->info(sprintf('CreateDB does not apply to "%s", skipped.', env('DB_CONNECTION')));
+
             return 0;
         }
         // try to set up a raw connection:
-        $dsn     = sprintf('mysql:host=%s;charset=utf8mb4', env('DB_HOST'));
+        $dsn     = sprintf('mysql:host=%s;port=%d;charset=utf8mb4', env('DB_HOST', 'localhost'), env('DB_PORT', '3306'));
         $options = [
             PDO::ATTR_ERRMODE            => PDO::ERRMODE_EXCEPTION,
             PDO::ATTR_DEFAULT_FETCH_MODE => PDO::FETCH_ASSOC,

app/Console/Commands/SetLatestVersion.php

@@ -25,6 +25,9 @@ namespace FireflyIII\Console\Commands;
 
 use Illuminate\Console\Command;
 
+/**
+ * Class SetLatestVersion
+ */
 class SetLatestVersion extends Command
 {
     /**
@@ -32,7 +35,7 @@ class SetLatestVersion extends Command
      *
      * @var string
      */
-    protected $description = 'Command description';
+    protected $description = 'Set latest version in DB.';
     /**
      * The name and signature of the console command.
      *
@@ -53,19 +56,22 @@ class SetLatestVersion extends Command
     /**
      * Execute the console command.
      *
-     * @return mixed
+     * @return int
      */
-    public function handle()
+    public function handle(): int
     {
         if (!$this->option('james-is-cool')) {
             $this->error('Am too!');
 
-            return;
+            return 0;
         }
         app('fireflyconfig')->set('db_version', config('firefly.db_version'));
         app('fireflyconfig')->set('ff3_version', config('firefly.version'));
         $this->line('Updated version.');
 
+        //Telemetry::string('db_version', config('firefly.db_version'));
+        //Telemetry::string('ff3_version', config('firefly.version'));
+
         return 0;
     }
 }

app/Events/AdminRequestedTestMessage.php

@@ -2,7 +2,7 @@
 
 /**
  * AdminRequestedTestMessage.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Events/Event.php

@@ -2,7 +2,7 @@
 
 /**
  * Event.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Events/RegisteredUser.php

@@ -2,7 +2,7 @@
 
 /**
  * RegisteredUser.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Events/RequestedNewPassword.php

@@ -2,7 +2,7 @@
 
 /**
  * RequestedNewPassword.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Events/RequestedReportOnJournals.php

@@ -2,7 +2,7 @@
 
 /**
  * RequestedReportOnJournals.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Events/RequestedVersionCheckStatus.php

@@ -2,7 +2,7 @@
 
 /**
  * RequestedVersionCheckStatus.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Events/StoredTransactionGroup.php

@@ -2,7 +2,7 @@
 
 /**
  * StoredTransactionGroup.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -36,6 +36,7 @@ class StoredTransactionGroup extends Event
 {
     use SerializesModels;
 
+    /** @var bool */
     public $applyRules;
     /** @var TransactionGroup The group that was stored. */
     public $transactionGroup;

app/Events/UpdatedTransactionGroup.php

@@ -2,7 +2,7 @@
 
 /**
  * UpdatedTransactionGroup.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -37,6 +37,8 @@ class UpdatedTransactionGroup extends Event
 {
     use SerializesModels;
 
+    /** @var bool */
+    public $applyRules;
     /** @var TransactionGroup The group that was stored. */
     public $transactionGroup;
 
@@ -45,8 +47,9 @@ class UpdatedTransactionGroup extends Event
      *
      * @param TransactionGroup $transactionGroup
      */
-    public function __construct(TransactionGroup $transactionGroup)
+    public function __construct(TransactionGroup $transactionGroup, bool $applyRules = true)
     {
         $this->transactionGroup = $transactionGroup;
+        $this->applyRules       = $applyRules;
     }
 }

app/Events/UserChangedEmail.php

@@ -2,7 +2,7 @@
 
 /**
  * UserChangedEmail.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Exceptions/DuplicateTransactionException.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * DuplicateTransactionException.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Exceptions/FireflyException.php

@@ -2,7 +2,7 @@
 
 /**
  * FireflyException.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Exceptions/GracefulNotFoundHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * GracefulNotFoundHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -30,6 +30,7 @@ use FireflyIII\Models\Attachment;
 use FireflyIII\Models\Bill;
 use FireflyIII\Models\TransactionGroup;
 use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\User;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
 use Illuminate\Http\Request;
@@ -65,6 +66,7 @@ class GracefulNotFoundHandler extends ExceptionHandler
 
                 return parent::render($request, $exception);
             case 'accounts.show':
+            case 'accounts.show.all':
                 return $this->handleAccount($request, $exception);
             case 'transactions.show':
                 return $this->handleGroup($request, $exception);
@@ -85,6 +87,7 @@ class GracefulNotFoundHandler extends ExceptionHandler
                 return redirect(route('currencies.index'));
                 break;
             case 'budgets.show':
+            case 'budgets.edit':
                 $request->session()->reflash();
 
                 return redirect(route('budgets.index'));
@@ -223,6 +226,10 @@ class GracefulNotFoundHandler extends ExceptionHandler
         $type = $journal->transactionType->type;
         $request->session()->reflash();
 
+        if (TransactionType::RECONCILIATION === $type) {
+            return redirect(route('accounts.index', ['asset']));
+        }
+
         return redirect(route('transactions.index', [strtolower($type)]));
 
     }

app/Exceptions/Handler.php

@@ -2,7 +2,7 @@
 
 /**
  * Handler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Exceptions/NotImplementedException.php

@@ -2,7 +2,7 @@
 
 /**
  * NotImplementedException.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Exceptions/ValidationException.php

@@ -2,7 +2,7 @@
 
 /**
  * ValidationException.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/AccountFactory.php

@@ -2,7 +2,7 @@
 
 /**
  * AccountFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/AccountMetaFactory.php

@@ -2,7 +2,7 @@
 
 /**
  * AccountMetaFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/AttachmentFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AttachmentFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/BillFactory.php

@@ -2,7 +2,7 @@
 
 /**
  * BillFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/BudgetFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * BudgetFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/CategoryFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CategoryFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/PiggyBankEventFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PiggyBankEventFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/PiggyBankFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PiggyBankFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/RecurrenceFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * RecurrenceFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/TagFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TagFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/TransactionCurrencyFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TransactionCurrencyFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/TransactionFactory.php

@@ -2,7 +2,7 @@
 
 /**
  * TransactionFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -25,6 +25,7 @@ declare(strict_types=1);
 namespace FireflyIII\Factory;
 
 
+use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Account;
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionCurrency;
@@ -102,12 +103,17 @@ class TransactionFactory
     /**
      * Create transaction with negative amount (for source accounts).
      *
-     * @param string $amount
+     * @param string      $amount
      * @param string|null $foreignAmount
-     * @return Transaction|null
+     *
+     * @return Transaction
+     * @throws FireflyException
      */
-    public function createNegative(string $amount, ?string $foreignAmount): ?Transaction
+    public function createNegative(string $amount, ?string $foreignAmount): Transaction
     {
+        if ('' === $foreignAmount) {
+            $foreignAmount = null;
+        }
         if (null !== $foreignAmount) {
             $foreignAmount = app('steam')->negative($foreignAmount);
         }
@@ -118,16 +124,20 @@ class TransactionFactory
     /**
      * Create transaction with positive amount (for destination accounts).
      *
-     * @param string $amount
+     * @param string      $amount
      * @param string|null $foreignAmount
-     * @return Transaction|null
+     *
+     * @return Transaction
+     * @throws FireflyException
      */
-    public function createPositive(string $amount, ?string $foreignAmount): ?Transaction
+    public function createPositive(string $amount, ?string $foreignAmount): Transaction
     {
+        if ('' === $foreignAmount) {
+            $foreignAmount = null;
+        }
         if (null !== $foreignAmount) {
             $foreignAmount = app('steam')->positive($foreignAmount);
         }
-
         return $this->create(app('steam')->positive($amount), $foreignAmount);
     }
 
@@ -151,14 +161,19 @@ class TransactionFactory
     }
 
     /**
-     * @param string $amount
+     * @param string      $amount
      * @param string|null $foreignAmount
-     * @return Transaction|null
+     *
+     * @return Transaction
+     * @throws FireflyException
      */
-    private function create(string $amount, ?string $foreignAmount): ?Transaction
+    private function create(string $amount, ?string $foreignAmount): Transaction
     {
         $result = null;
-        $data   = [
+        if ('' === $foreignAmount) {
+            $foreignAmount = null;
+        }
+        $data = [
             'reconciled'              => $this->reconciled,
             'account_id'              => $this->account->id,
             'transaction_journal_id'  => $this->journal->id,
@@ -174,6 +189,12 @@ class TransactionFactory
             // @codeCoverageIgnoreStart
         } catch (QueryException $e) {
             Log::error(sprintf('Could not create transaction: %s', $e->getMessage()), $data);
+            Log::error($e->getMessage());
+            Log::error($e->getTraceAsString());
+            throw new FireflyException('Query exception when creating transaction.');
+        }
+        if (null === $result) {
+            throw new FireflyException('Transaction is NULL.');
         }
         // @codeCoverageIgnoreEnd
         if (null !== $result) {
@@ -185,7 +206,7 @@ class TransactionFactory
             );
 
             // do foreign currency thing: add foreign currency info to $one and $two if necessary.
-            if (null !== $this->foreignCurrency && null !== $foreignAmount && $this->foreignCurrency->id !== $this->currency->id) {
+            if (null !== $this->foreignCurrency && null !== $foreignAmount && $this->foreignCurrency->id !== $this->currency->id && '' !== $foreignAmount) {
                 $result->foreign_currency_id = $this->foreignCurrency->id;
                 $result->foreign_amount      = $foreignAmount;
 

app/Factory/TransactionGroupFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TransactionGroupFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -24,8 +24,10 @@ declare(strict_types=1);
 namespace FireflyIII\Factory;
 
 use FireflyIII\Exceptions\DuplicateTransactionException;
+use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\TransactionGroup;
 use FireflyIII\User;
+use Log;
 
 /**
  * Class TransactionGroupFactory
@@ -59,8 +61,12 @@ class TransactionGroupFactory
     {
         $this->journalFactory->setUser($this->user);
         $this->journalFactory->setErrorOnHash($data['error_if_duplicate_hash'] ?? false);
-
-        $collection = $this->journalFactory->create($data);
+        try {
+            $collection = $this->journalFactory->create($data);
+        } catch(DuplicateTransactionException $e) {
+            Log::warning('GroupFactory::create() caught journalFactory::create() with a duplicate!');
+            throw new DuplicateTransactionException($e->getMessage());
+        }
         $title      = $data['group_title'] ?? null;
         $title      = '' === $title ? null : $title;
 

app/Factory/TransactionJournalFactory.php

@@ -2,7 +2,7 @@
 
 /**
  * TransactionJournalFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -29,6 +29,7 @@ use Exception;
 use FireflyIII\Exceptions\DuplicateTransactionException;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Account;
+use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionCurrency;
 use FireflyIII\Models\TransactionJournal;
 use FireflyIII\Models\TransactionJournalMeta;
@@ -40,6 +41,7 @@ use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
 use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
 use FireflyIII\Repositories\TransactionType\TransactionTypeRepositoryInterface;
+use FireflyIII\Services\Internal\Destroy\JournalDestroyService;
 use FireflyIII\Services\Internal\Support\JournalServiceTrait;
 use FireflyIII\Support\NullArrayObject;
 use FireflyIII\User;
@@ -125,33 +127,45 @@ class TransactionJournalFactory
      *
      * @return Collection
      * @throws DuplicateTransactionException
+     * @throws FireflyException
      */
     public function create(array $data): Collection
     {
         // convert to special object.
-        $data = new NullArrayObject($data);
+        $dataObject = new NullArrayObject($data);
 
         Log::debug('Start of TransactionJournalFactory::create()');
         $collection   = new Collection;
-        $transactions = $data['transactions'] ?? [];
+        $transactions = $dataObject['transactions'] ?? [];
         if (0 === count($transactions)) {
             Log::error('There are no transactions in the array, the TransactionJournalFactory cannot continue.');
 
             return new Collection;
         }
-
-        /** @var array $row */
-        foreach ($transactions as $index => $row) {
-            Log::debug(sprintf('Now creating journal %d/%d', $index + 1, count($transactions)));
-
-            Log::debug('Going to call createJournal', $row);
-            $journal = $this->createJournal(new NullArrayObject($row));
-            if (null !== $journal) {
-                $collection->push($journal);
-            }
-            if (null === $journal) {
-                Log::error('The createJournal() method returned NULL. This may indicate an error.');
+        try {
+            /** @var array $row */
+            foreach ($transactions as $index => $row) {
+                Log::debug(sprintf('Now creating journal %d/%d', $index + 1, count($transactions)));
+                $journal = $this->createJournal(new NullArrayObject($row));
+                if (null !== $journal) {
+                    $collection->push($journal);
+                }
+                if (null === $journal) {
+                    Log::error('The createJournal() method returned NULL. This may indicate an error.');
+                }
             }
+        } catch (DuplicateTransactionException $e) {
+            Log::warning('TransactionJournalFactory::create() caught a duplicate journal in createJournal()');
+            Log::error($e->getMessage());
+            Log::error($e->getTraceAsString());
+            $this->forceDeleteOnError($collection);
+            throw new DuplicateTransactionException($e->getMessage());
+        } catch (FireflyException $e) {
+            Log::warning('TransactionJournalFactory::create() caught an exception.');
+            Log::error($e->getMessage());
+            Log::error($e->getTraceAsString());
+            $this->forceDeleteOnError($collection);
+            throw new FireflyException($e->getMessage());
         }
 
         return $collection;
@@ -199,7 +213,7 @@ class TransactionJournalFactory
      * @param NullArrayObject $row
      *
      * @return TransactionJournal|null
-     * @throws Exception
+     * @throws FireflyException
      * @throws DuplicateTransactionException
      */
     private function createJournal(NullArrayObject $row): ?TransactionJournal
@@ -227,36 +241,33 @@ class TransactionJournalFactory
         try {
             // validate source and destination using a new Validator.
             $this->validateAccounts($row);
-            /** create or get source and destination accounts  */
-
-            $sourceInfo = [
-                'id'     => (int)$row['source_id'],
-                'name'   => $row['source_name'],
-                'iban'   => $row['source_iban'],
-                'number' => $row['source_number'],
-                'bic'    => $row['source_bic'],
-            ];
-
-            $destInfo = [
-                'id'     => (int)$row['destination_id'],
-                'name'   => $row['destination_name'],
-                'iban'   => $row['destination_iban'],
-                'number' => $row['destination_number'],
-                'bic'    => $row['destination_bic'],
-            ];
-            Log::debug('Source info:', $sourceInfo);
-            Log::debug('Destination info:', $destInfo);
-
-            $sourceAccount      = $this->getAccount($type->type, 'source', $sourceInfo);
-            $destinationAccount = $this->getAccount($type->type, 'destination', $destInfo);
-            // @codeCoverageIgnoreStart
         } catch (FireflyException $e) {
             Log::error('Could not validate source or destination.');
             Log::error($e->getMessage());
 
             return null;
         }
-        // @codeCoverageIgnoreEnd
+        /** create or get source and destination accounts  */
+        $sourceInfo = [
+            'id'     => (int)$row['source_id'],
+            'name'   => $row['source_name'],
+            'iban'   => $row['source_iban'],
+            'number' => $row['source_number'],
+            'bic'    => $row['source_bic'],
+        ];
+
+        $destInfo = [
+            'id'     => (int)$row['destination_id'],
+            'name'   => $row['destination_name'],
+            'iban'   => $row['destination_iban'],
+            'number' => $row['destination_number'],
+            'bic'    => $row['destination_bic'],
+        ];
+        Log::debug('Source info:', $sourceInfo);
+        Log::debug('Destination info:', $destInfo);
+
+        $sourceAccount      = $this->getAccount($type->type, 'source', $sourceInfo);
+        $destinationAccount = $this->getAccount($type->type, 'destination', $destInfo);
 
         // TODO AFTER 4.8,0 better handling below:
 
@@ -332,7 +343,15 @@ class TransactionJournalFactory
         $transactionFactory->setCurrency($sourceCurrency);
         $transactionFactory->setForeignCurrency($sourceForeignCurrency);
         $transactionFactory->setReconciled($row['reconciled'] ?? false);
-        $transactionFactory->createNegative((string)$row['amount'], (string)$row['foreign_amount']);
+        try {
+            $negative = $transactionFactory->createNegative((string)$row['amount'], (string)$row['foreign_amount']);
+        } catch (FireflyException $e) {
+            Log::error('Exception creating negative transaction.');
+            Log::error($e->getMessage());
+            Log::error($e->getTraceAsString());
+            $this->forceDeleteOnError(new Collection([$journal]));
+            throw new FireflyException($e->getMessage());
+        }
 
         // and the destination one:
         /** @var TransactionFactory $transactionFactory */
@@ -343,7 +362,18 @@ class TransactionJournalFactory
         $transactionFactory->setCurrency($destCurrency);
         $transactionFactory->setForeignCurrency($destForeignCurrency);
         $transactionFactory->setReconciled($row['reconciled'] ?? false);
-        $transactionFactory->createPositive((string)$row['amount'], (string)$row['foreign_amount']);
+        try {
+            $transactionFactory->createPositive((string)$row['amount'], (string)$row['foreign_amount']);
+        } catch (FireflyException $e) {
+            Log::error('Exception creating positive transaction.');
+            Log::error($e->getMessage());
+            Log::error($e->getTraceAsString());
+            Log::warning('Delete negative transaction.');
+            $this->forceTrDelete($negative);
+            $this->forceDeleteOnError(new Collection([$journal]));
+            throw new FireflyException($e->getMessage());
+        }
+
 
         // verify that journal has two transactions. Otherwise, delete and cancel.
         // TODO this can't be faked so it can't be tested.
@@ -395,21 +425,55 @@ class TransactionJournalFactory
      */
     private function errorIfDuplicate(string $hash): void
     {
+        Log::debug(sprintf('In errorIfDuplicate(%s)', $hash));
         if (false === $this->errorOnHash) {
             return;
         }
         $result = null;
         if ($this->errorOnHash) {
+            Log::debug('Will verify duplicate!');
             /** @var TransactionJournalMeta $result */
             $result = TransactionJournalMeta::where('data', json_encode($hash, JSON_THROW_ON_ERROR))
                                             ->with(['transactionJournal', 'transactionJournal.transactionGroup'])
                                             ->first();
         }
         if (null !== $result) {
+            Log::warning('Found a duplicate!');
             throw new DuplicateTransactionException(sprintf('Duplicate of transaction #%d.', $result->transactionJournal->transaction_group_id));
         }
     }
 
+    /**
+     * Force the deletion of an entire set of transaction journals and their meta object in case of
+     * an error creating a group.
+     *
+     * @param Collection $collection
+     */
+    private function forceDeleteOnError(Collection $collection): void
+    {
+        Log::debug(sprintf('forceDeleteOnError on collection size %d item(s)', $collection->count()));
+        $service = app(JournalDestroyService::class);
+        /** @var TransactionJournal $journal */
+        foreach ($collection as $journal) {
+            Log::debug(sprintf('forceDeleteOnError on journal #%d', $journal->id));
+            $service->destroy($journal);
+        }
+    }
+
+    /**
+     * @param Transaction $transaction
+     */
+    private function forceTrDelete(Transaction $transaction): void
+    {
+        try {
+            $transaction->delete();
+        } catch (Exception $e) {
+            Log::error($e->getMessage());
+            Log::error($e->getTraceAsString());
+            Log::error('Could not delete negative transaction.');
+        }
+    }
+
     /**
      * @param TransactionCurrency|null $currency
      * @param Account                  $account
@@ -526,6 +590,9 @@ class TransactionJournalFactory
     public function setErrorOnHash(bool $errorOnHash): void
     {
         $this->errorOnHash = $errorOnHash;
+        if (true === $errorOnHash) {
+            Log::info('Will trigger duplication alert for this journal.');
+        }
     }
 
 

app/Factory/TransactionJournalMetaFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * TransactionJournalMetaFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Factory/TransactionTypeFactory.php

@@ -2,7 +2,7 @@
 
 /**
  * TransactionTypeFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Chart/Basic/ChartJsGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ChartJsGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -32,6 +32,7 @@ class ChartJsGenerator implements GeneratorInterface
 {
     /**
      * Constructor.
+     *
      * @codeCoverageIgnore
      */
     public function __construct()
@@ -118,7 +119,10 @@ class ChartJsGenerator implements GeneratorInterface
     public function multiSet(array $data): array
     {
         reset($data);
-        $first  = current($data);
+        $first = current($data);
+        if (!is_array($first)) {
+            return [];
+        }
         $labels = is_array($first['entries']) ? array_keys($first['entries']) : [];
 
         $chartData = [
@@ -186,7 +190,7 @@ class ChartJsGenerator implements GeneratorInterface
             $chartData['datasets'][0]['data'][]            = (float)app('steam')->positive((string)$value);
             $chartData['datasets'][0]['backgroundColor'][] = ChartColour::getColour($index);
 
-            $chartData['labels'][]                         = $key;
+            $chartData['labels'][] = $key;
             ++$index;
         }
 

app/Generator/Chart/Basic/GeneratorInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * GeneratorInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Account/MonthReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MonthReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Account/MultiYearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MultiYearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Account/YearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * YearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Audit/MonthReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MonthReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Audit/MultiYearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MultiYearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Audit/YearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * YearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Budget/MonthReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MonthReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Budget/MultiYearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MultiYearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Budget/YearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * YearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Category/MonthReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MonthReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Category/MultiYearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MultiYearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Category/YearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * YearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/ReportGeneratorFactory.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReportGeneratorFactory.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/ReportGeneratorInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReportGeneratorInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Standard/MonthReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MonthReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Standard/MultiYearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MultiYearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Standard/YearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * YearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Tag/MonthReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MonthReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Tag/MultiYearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * MultiYearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Generator/Report/Tag/YearReportGenerator.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * YearReportGenerator.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Handlers/Events/APIEventHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * APIEventHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Handlers/Events/AdminEventHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AdminEventHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Handlers/Events/AutomationHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AutomationHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Handlers/Events/StoredGroupEventHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * StoredGroupEventHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -35,21 +35,23 @@ class StoredGroupEventHandler
     /**
      * This method grabs all the users rules and processes them.
      *
-     * @param StoredTransactionGroup $storedJournalEvent
+     * @param StoredTransactionGroup $storedGroupEvent
      */
-    public function processRules(StoredTransactionGroup $storedJournalEvent): void
+    public function processRules(StoredTransactionGroup $storedGroupEvent): void
     {
-        if (false === $storedJournalEvent->applyRules) {
+        if (false === $storedGroupEvent->applyRules) {
+            Log::info(sprintf('Will not run rules on group #%d', $storedGroupEvent->transactionGroup->id));
+
             return;
         }
         Log::debug('Now in StoredGroupEventHandler::processRules()');
 
         /** @var RuleEngine $ruleEngine */
         $ruleEngine = app(RuleEngine::class);
-        $ruleEngine->setUser($storedJournalEvent->transactionGroup->user);
+        $ruleEngine->setUser($storedGroupEvent->transactionGroup->user);
         $ruleEngine->setAllRules(true);
         $ruleEngine->setTriggerMode(RuleEngine::TRIGGER_STORE);
-        $journals = $storedJournalEvent->transactionGroup->transactionJournals;
+        $journals = $storedGroupEvent->transactionGroup->transactionJournals;
 
         /** @var TransactionJournal $journal */
         foreach ($journals as $journal) {

app/Handlers/Events/UpdatedGroupEventHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * UpdatedGroupEventHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -35,16 +35,22 @@ class UpdatedGroupEventHandler
     /**
      * This method will check all the rules when a journal is updated.
      *
-     * @param UpdatedTransactionGroup $updatedJournalEvent
+     * @param UpdatedTransactionGroup $updatedGroupEvent
      */
-    public function processRules(UpdatedTransactionGroup $updatedJournalEvent): void
+    public function processRules(UpdatedTransactionGroup $updatedGroupEvent): void
     {
+        if (false === $updatedGroupEvent->applyRules) {
+            Log::info(sprintf('Will not run rules on group #%d', $updatedGroupEvent->transactionGroup->id));
+
+            return;
+        }
+
         /** @var RuleEngine $ruleEngine */
         $ruleEngine = app(RuleEngine::class);
-        $ruleEngine->setUser($updatedJournalEvent->transactionGroup->user);
+        $ruleEngine->setUser($updatedGroupEvent->transactionGroup->user);
         $ruleEngine->setAllRules(true);
         $ruleEngine->setTriggerMode(RuleEngine::TRIGGER_UPDATE);
-        $journals = $updatedJournalEvent->transactionGroup->transactionJournals;
+        $journals = $updatedGroupEvent->transactionGroup->transactionJournals;
 
         /** @var TransactionJournal $journal */
         foreach ($journals as $journal) {

app/Handlers/Events/UserEventHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * UserEventHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Handlers/Events/VersionCheckEventHandler.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * VersionCheckEventHandler.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -25,6 +25,7 @@ declare(strict_types=1);
 namespace FireflyIII\Handlers\Events;
 
 
+use Carbon\Carbon;
 use FireflyIII\Events\RequestedVersionCheckStatus;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Helpers\Update\UpdateTrait;
@@ -55,7 +56,6 @@ class VersionCheckEventHandler
         $value      = (int)$permission->data;
         if (1 !== $value) {
             Log::info('Update check is not enabled.');
-
             return;
         }
 
@@ -65,7 +65,6 @@ class VersionCheckEventHandler
         $user = $event->user;
         if (!$repository->hasRole($user, 'owner')) {
             Log::debug('User is not admin, done.');
-
             return;
         }
 
@@ -76,26 +75,13 @@ class VersionCheckEventHandler
         Log::debug(sprintf('Last check time is %d, current time is %d, difference is %d', $lastCheckTime->data, $now, $diff));
         if ($diff < 604800) {
             Log::debug(sprintf('Checked for updates less than a week ago (on %s).', date('Y-m-d H:i:s', $lastCheckTime->data)));
-
             return;
         }
         // last check time was more than a week ago.
         Log::debug('Have not checked for a new version in a week!');
-        try {
-            $latestRelease = $this->getLatestRelease();
-        } catch (FireflyException $e) {
-            Log::error($e);
-            session()->flash('error', (string)trans('firefly.update_check_error'));
+        $release      = $this->getLatestRelease();
 
-            // softfail.
-            return;
-        }
-        $versionCheck  = $this->versionCheck($latestRelease);
-        $resultString  = $this->parseResult($versionCheck, $latestRelease);
-        if (0 !== $versionCheck && '' !== $resultString) {
-            // flash info
-            session()->flash('info', $resultString);
-        }
+        session()->flash($release['level'], $release['message']);
         app('fireflyconfig')->set('last_update_check', time());
     }
 }

app/Helpers/Attachments/AttachmentHelper.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AttachmentHelper.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Attachments/AttachmentHelperInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * AttachmentHelperInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Collector/GroupCollector.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * GroupCollector.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -60,6 +60,8 @@ class GroupCollector implements GroupCollectorInterface
     private $hasCatInformation;
     /** @var bool Will be true of the query has the tag info tables joined. */
     private $hasJoinedTagTables;
+    /** @var bool Will be true for attachments */
+    private $hasJoinedAttTables;
     /** @var int The maximum number of results. */
     private $limit;
     /** @var int The page to return. */
@@ -86,7 +88,8 @@ class GroupCollector implements GroupCollectorInterface
         $this->hasBudgetInformation = false;
         $this->hasBillInformation   = false;
         $this->hasJoinedTagTables   = false;
-        $this->integerFields = [
+        $this->hasJoinedAttTables   = false;
+        $this->integerFields        = [
             'transaction_group_id',
             'user_id',
             'transaction_journal_id',
@@ -101,10 +104,10 @@ class GroupCollector implements GroupCollectorInterface
             'destination_transaction_id',
             'destination_account_id',
             'category_id',
-            'budget_id'
+            'budget_id',
         ];
-        $this->total  = 0;
-        $this->fields = [
+        $this->total                = 0;
+        $this->fields               = [
             # group
             'transaction_groups.id as transaction_group_id',
             'transaction_groups.user_id as user_id',
@@ -281,11 +284,10 @@ class GroupCollector implements GroupCollectorInterface
      */
     public function getGroups(): Collection
     {
-        $start = microtime(true);
+        //$start = microtime(true);
         /** @var Collection $result */
         $result = $this->query->get($this->fields);
-        $end    = round(microtime(true) - $start, 5);
-
+        //$end    = round(microtime(true) - $start, 5);
         // log info about query time.
         //Log::info(sprintf('Query took Firefly III %s seconds', $end));
         //Log::info($this->query->toSql(), $this->query->getBindings());
@@ -950,6 +952,24 @@ class GroupCollector implements GroupCollectorInterface
         }
     }
 
+    /**
+     * Join table to get attachment information.
+     */
+    private function joinAttachmentTables(): void
+    {
+        if (false === $this->hasJoinedAttTables) {
+            // join some extra tables:
+            $this->hasJoinedAttTables = true;
+            $this->query->leftJoin('attachments', 'attachments.attachable_id', '=', 'transaction_journals.id')
+                        ->where(
+                            static function (EloquentBuilder $q1) {
+                                $q1->where('attachments.attachable_type', TransactionJournal::class);
+                                $q1->orWhereNull('attachments.attachable_type');
+                            }
+                        );
+        }
+    }
+
     /**
      * @param array              $existingJournal
      * @param TransactionJournal $newJournal
@@ -980,6 +1000,26 @@ class GroupCollector implements GroupCollectorInterface
         return $existingJournal;
     }
 
+    /**
+     * @param array              $existingJournal
+     * @param TransactionJournal $newJournal
+     *
+     * @return array
+     */
+    private function mergeAttachments(array $existingJournal, TransactionJournal $newJournal): array
+    {
+        $newArray = $newJournal->toArray();
+        if (isset($newArray['attachment_id'])) {
+            $attachmentId                                  = (int)$newJournal['tag_id'];
+            $existingJournal['attachments'][$attachmentId] = [
+                'id' => $attachmentId,
+            ];
+        }
+
+        return $existingJournal;
+    }
+
+
     /**
      * @param Collection $collection
      *
@@ -994,7 +1034,7 @@ class GroupCollector implements GroupCollectorInterface
 
             if (!isset($groups[$groupId])) {
                 // make new array
-                $parsedGroup                            = $this->parseAugmentedGroup($augumentedJournal);
+                $parsedGroup                            = $this->parseAugmentedJournal($augumentedJournal);
                 $groupArray                             = [
                     'id'               => (int)$augumentedJournal->transaction_group_id,
                     'user_id'          => (int)$augumentedJournal->user_id,
@@ -1014,11 +1054,14 @@ class GroupCollector implements GroupCollectorInterface
             $groups[$groupId]['count']++;
 
             if (isset($groups[$groupId]['transactions'][$journalId])) {
+                // append data to existing group + journal (for multiple tags or multiple attachments)
                 $groups[$groupId]['transactions'][$journalId] = $this->mergeTags($groups[$groupId]['transactions'][$journalId], $augumentedJournal);
+                $groups[$groupId]['transactions'][$journalId] = $this->mergeAttachments($groups[$groupId]['transactions'][$journalId], $augumentedJournal);
             }
 
             if (!isset($groups[$groupId]['transactions'][$journalId])) {
-                $groups[$groupId]['transactions'][$journalId] = $this->parseAugmentedGroup($augumentedJournal);
+                // create second, third, fourth split:
+                $groups[$groupId]['transactions'][$journalId] = $this->parseAugmentedJournal($augumentedJournal);
             }
 
 
@@ -1034,10 +1077,11 @@ class GroupCollector implements GroupCollectorInterface
      *
      * @return array
      */
-    private function parseAugmentedGroup(TransactionJournal $augumentedJournal): array
+    private function parseAugmentedJournal(TransactionJournal $augumentedJournal): array
     {
-        $result         = $augumentedJournal->toArray();
-        $result['tags'] = [];
+        $result                = $augumentedJournal->toArray();
+        $result['tags']        = [];
+        $result['attachments'] = [];
         try {
             $result['date']       = new Carbon($result['date']);
             $result['created_at'] = new Carbon($result['created_at']);
@@ -1067,6 +1111,14 @@ class GroupCollector implements GroupCollectorInterface
             ];
         }
 
+        // also merge attachments:
+        if (isset($augumentedJournal['attachment_id'])) {
+            $attachmentId                         = (int)$augumentedJournal['attachment_id'];
+            $result['attachments'][$attachmentId] = [
+                'id' => $attachmentId,
+            ];
+        }
+
         return $result;
     }
 
@@ -1230,4 +1282,15 @@ class GroupCollector implements GroupCollectorInterface
 
         return $this;
     }
+
+    /**
+     * @inheritDoc
+     */
+    public function withAttachmentInformation(): GroupCollectorInterface
+    {
+        $this->fields[] = 'attachments.id as attachment_id';
+        $this->joinAttachmentTables();
+
+        return $this;
+    }
 }

app/Helpers/Collector/GroupCollectorInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * GroupCollectorInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -57,6 +57,13 @@ interface GroupCollectorInterface
      */
     public function amountLess(string $amount): GroupCollectorInterface;
 
+    /**
+     * Add basic info on attachments of transactions.
+     *
+     * @return GroupCollectorInterface
+     */
+    public function withAttachmentInformation(): GroupCollectorInterface;
+
     /**
      * Get transactions where the amount is more than.
      *

app/Helpers/Fiscal/FiscalHelper.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * FiscalHelper.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Fiscal/FiscalHelperInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * FiscalHelperInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Help/Help.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * Help.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Help/HelpInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * HelpInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Report/NetWorth.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * NetWorth.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Report/NetWorthInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * NetWorthInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Report/PopupReport.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PopupReport.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Report/PopupReportInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * PopupReportInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Report/ReportHelper.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReportHelper.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Report/ReportHelperInterface.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReportHelperInterface.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Helpers/Update/UpdateTrait.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * UpdateTrait.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *
@@ -23,8 +23,6 @@ declare(strict_types=1);
 
 namespace FireflyIII\Helpers\Update;
 
-use Carbon\Carbon;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Services\FireflyIIIOrg\Update\UpdateRequestInterface;
 use Log;
 
@@ -35,10 +33,11 @@ use Log;
 trait UpdateTrait
 {
     /**
-     * Get object for the latest release from GitHub.
+     * Returns an array with info on the next release, if any.
+     * 'message' => 'A new version is available.
+     * 'level' => 'info' / 'success' / 'error'
      *
      * @return array
-     * @throws FireflyException
      */
     public function getLatestRelease(): array
     {
@@ -47,81 +46,6 @@ trait UpdateTrait
         $checker = app(UpdateRequestInterface::class);
         $channel = app('fireflyconfig')->get('update_channel', 'stable')->data;
 
-        return $checker->getVersion($channel);
-    }
-
-    /**
-     * Parses the version check result in a human readable sentence.
-     *
-     * @param int   $versionCheck
-     * @param array $information
-     *
-     * @return string
-     */
-    public function parseResult(int $versionCheck, array $information): string
-    {
-        Log::debug(sprintf('Now in parseResult(%d)', $versionCheck));
-        $current   = (string)config('firefly.version');
-        $return    = '';
-        $triggered = false;
-        if (-1 === $versionCheck) {
-            $triggered         = true;
-            $monthAndDayFormat = (string)trans('config.month_and_day');
-            $carbon            = Carbon::createFromFormat('Y-m-d', $information['date']);
-            $return            = (string)trans(
-                'firefly.update_new_version_alert',
-                [
-                    'your_version' => $current,
-                    'new_version'  => $information['version'],
-                    'date'         => $carbon->formatLocalized($monthAndDayFormat),
-                ]
-            );
-            // append warning if beta or alpha.
-            $isBeta = $information['is_beta'] ?? false;
-            if (true === $isBeta) {
-                $return = sprintf('%s %s', $return, trans('firefly.update_version_beta'));
-            }
-
-            $isAlpha = $information['is_alpha'] ?? false;
-            if (true === $isAlpha) {
-                $return = sprintf('%s %s', $return, trans('firefly.update_version_alpha'));
-            }
-        }
-
-        if (0 === $versionCheck) {
-            $triggered = true;
-            Log::debug('User is running current version.');
-            // you are running the current version!
-            $return = (string)trans('firefly.update_current_version_alert', ['version' => $current]);
-        }
-        if (1 === $versionCheck) {
-            $triggered = true;
-            Log::debug('User is running NEWER version.');
-            // you are running a newer version!
-            $return = (string)trans('firefly.update_newer_version_alert', ['your_version' => $current, 'new_version' => $information['version']]);
-        }
-        if (false === $triggered) {
-            Log::debug('No option was triggered.');
-            $return = (string)trans('firefly.update_check_error');
-        }
-
-        return $return;
-    }
-
-    /**
-     * Compare version and store result.
-     *
-     * @param array $information
-     *
-     * @return int
-     */
-    public function versionCheck(array $information): int
-    {
-        Log::debug('Now in versionCheck()');
-        $current = (string)config('firefly.version');
-        $check   = version_compare($current, $information['version']);
-        Log::debug(sprintf('Comparing %s with %s, result is %s', $current, $information['version'], $check), $information);
-
-        return $check;
+        return $checker->getUpdateInformation($channel);
     }
 }

app/Http/Controllers/Account/CreateController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * CreateController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Account/DeleteController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * DeleteController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Account/EditController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * EditController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Account/IndexController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * IndexController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Account/ReconcileController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ReconcileController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Account/ShowController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ShowController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Admin/ConfigurationController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * ConfigurationController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Admin/HomeController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * HomeController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *

app/Http/Controllers/Admin/LinkController.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * LinkController.php
- * Copyright (c) 2019 thegrumpydictator@gmail.com
+ * Copyright (c) 2019 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
  *